Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of "==" and "!=" confusing to non-programmers, update operators to strings #1525

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

Feedback from a customer meeting: When the dashboard was using '!=' they didn't appreciate that this meant "Not Equal" - similarly "==" didn't mean anything to them. We should probably use more widely understood operators.

Acceptance criteria:
Age == 41: Age equal to 41
Age != 41: Age not equal to 41
Age < 41: Age less than 41
Age > 41: Age greater than 41

Description

For causal treatment policy:
Before:
image

After:
image

For cohort filter list:
Before:
image

After:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #1525 (1f2556b) into main (0a303e6) will decrease coverage by 2.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   87.27%   84.89%   -2.39%     
==========================================
  Files         108       57      -51     
  Lines        5108     2886    -2222     
==========================================
- Hits         4458     2450    -2008     
+ Misses        650      436     -214     
Flag Coverage Δ
unittests 84.89% <ø> (-2.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ai/responsibleai/_tools/causal/causal_constants.py
...nsibleai/responsibleai/_managers/causal_manager.py
...sponsibleai/responsibleai/managers/base_manager.py
responsibleai/responsibleai/_managers/__init__.py
responsibleai/responsibleai/__init__.py
...i/responsibleai/managers/error_analysis_manager.py
...ai/databalanceanalysis/feature_balance_measures.py
responsibleai/responsibleai/__version__.py
responsibleai/responsibleai/_internal/constants.py
responsibleai/responsibleai/_input_processing.py
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a303e6...1f2556b. Read the comment docs.

1 similar comment
@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 29, 2022 01:13
@romanlutz
Copy link
Contributor

These changes are great @tongyu-microsoft !

I remembered this occurrence as well:
image

@tongyu-microsoft tongyu-microsoft merged commit b56f431 into main Jun 29, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/updateEqualSymbols branch June 29, 2022 02:52
@tongyu-microsoft
Copy link
Contributor Author

These changes are great @tongyu-microsoft !

I remembered this occurrence as well: image

Thanks for pointing that out! I missed that one and will update it in next PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants