Model overview: use unique key to avoid heatmap color mismatch #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 108 108
Lines 5108 5108
=======================================
Hits 4458 4458
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1 similar comment
imatiach-msft
approved these changes
Jun 24, 2022
xuke444
approved these changes
Jun 24, 2022
xuke444
reviewed
Jun 24, 2022
...el-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/CohortStatsHeatmap.tsx
Outdated
Show resolved
Hide resolved
…olbox into romanlutz/add_new_cohorts_to_model_overview
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's (what I suspect to be) a bug in highcharts that makes certain colors (like the one we use for N/A cells) stay even when the underlying data of the heatmap changes. This was discovered by @tongyu-microsoft.
The solution is to make sure the
keywe pass is not reused so that we force highcharts to regenerate the entire heatmap. For that purpose, this PR uses a key consisting of the first letters of all cohorts and first letters of all selected metrics. If either of those dimensions of the heatmap change it should regenerate the heatmap. Theoretically, a collision of this primitive "hash function" is possible. It is rather unlikely, though, and seems to only matter if one of the cells has N/A content.Checklist