Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold input text for values that have changed from the original reference values for counterfactual list #1516

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

@tongyu-microsoft tongyu-microsoft commented Jun 23, 2022

In what if counterfactual list view, if a value has changed from the original reference values, it should be bolded in the text input box.

Description

Before:
The bottom row for creating new what if counterfactual point is not bolded:
image

After:
For features that are changed from the original reference values, they are bolded; We don't bold input values that are the same as original reference values:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

Codecov Report

Merging #1516 (7b70f20) into main (26b4f97) will decrease coverage by 2.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
- Coverage   87.27%   84.89%   -2.39%     
==========================================
  Files         108       57      -51     
  Lines        5108     2886    -2222     
==========================================
- Hits         4458     2450    -2008     
+ Misses        650      436     -214     
Flag Coverage Δ
unittests 84.89% <ø> (-2.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponsibleai/responsibleai/_tools/causal/__init__.py
.../responsibleai/modelanalysis/constants/__init__.py
...nsibleai/responsibleai/_managers/causal_manager.py
responsibleai/responsibleai/_internal/constants.py
.../databalanceanalysis/aggregate_balance_measures.py
responsibleai/responsibleai/_data_validations.py
...i/responsibleai/managers/counterfactual_manager.py
...ibleai/_tools/shared/state_directory_management.py
...onsibleai/_tools/shared/attribute_serialization.py
...sibleai/responsibleai/rai_insights/rai_insights.py
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b4f97...7b70f20. Read the comment docs.

2 similar comments
@tongyu-microsoft tongyu-microsoft merged commit b4ba63c into main Jun 24, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/cfStyle branch June 24, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants