Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Balance UX Part 1: add data_balance_measures to IDataset #1511

Merged
merged 11 commits into from
Jul 13, 2022

Conversation

ms-kashyap
Copy link
Collaborator

Description

This introduces the data schema of data balance measures.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1511 (224a5f9) into main (5f90591) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files         109      109           
  Lines        5260     5260           
=======================================
  Hits         4615     4615           
  Misses        645      645           
Flag Coverage Δ
unittests 87.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f90591...224a5f9. Read the comment docs.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have further comments other than what I pointed out already. I strongly suggest waiting for @imatiach-msft and @xuke444 to review. @gaugup may also be interested but I he may not be able to review in the next few days.

1 similar comment
Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imatiach-msft imatiach-msft merged commit f05e096 into main Jul 13, 2022
@imatiach-msft imatiach-msft deleted the ms-kashyap/databalanceux1 branch July 13, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants