Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: turn on heatmap colors by default #1510

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

romanlutz
Copy link
Contributor

Description

Per popular request, this PR turns on the heatmap colors by default. This only shows up with the second cohort, of course, since there's no gradient with a single cohort:

image

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from xuke444 as a code owner June 21, 2022 14:34
@codecov-commenter
Copy link

Codecov Report

Merging #1510 (8b79669) into main (a33d2ac) will increase coverage by 4.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   80.37%   84.89%   +4.51%     
==========================================
  Files          41       57      +16     
  Lines        1687     2886    +1199     
==========================================
+ Hits         1356     2450    +1094     
- Misses        331      436     +105     
Flag Coverage Δ
unittests 84.89% <ø> (+4.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
erroranalysis/erroranalysis/analyzer/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/version.py 100.00% <0.00%> (ø)
...is/erroranalysis/_internal/surrogate_error_tree.py 85.80% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/utils.py 84.61% <0.00%> (ø)
...ranalysis/erroranalysis/_internal/matrix_filter.py 95.85% <0.00%> (ø)
erroranalysis/erroranalysis/report/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/_internal/__init__.py 100.00% <0.00%> (ø)
...ranalysis/erroranalysis/_internal/cohort_filter.py 89.06% <0.00%> (ø)
...ranalysis/erroranalysis/analyzer/error_analyzer.py 92.89% <0.00%> (ø)
...erroranalysis/_internal/error_analyzer/__init__.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33d2ac...8b79669. Read the comment docs.

@romanlutz romanlutz merged commit e71bc37 into main Jun 22, 2022
@romanlutz romanlutz deleted the romanlutz/heatmap_default branch June 22, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants