-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model overview: use spline instead of line chart #1508
Conversation
@romanlutz what do you think about giving them the option of doing both? The spline can be misleading in many cases. |
Codecov Report
@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 89.30% 87.27% -2.03%
==========================================
Files 38 108 +70
Lines 1617 5108 +3491
==========================================
+ Hits 1444 4458 +3014
- Misses 173 650 +477
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Technically, this should be a histogram. However, we didn't find a good way to make a histogram with multiple cohorts that can still be read in a meaningful way (we tried...). The alternative was the line chart. The lines are actually just there to connect the dots, otherwise you would have a tough time figuring out which dots belong together. I think the general perception was that the pure line chart is terribly ugly and nobody wants to look at it. The splines are much more visually pleasing. However, I agree on them having the potential to mislead. That said, we're not saying that this is the actual probability distribution, but just a spline chart of counts (if you look at the axis and toggle). Two things are still missing here IMO that will also help:
Anyway, we can bring this up with PM to see if there's a need to have the pure line chart, too. Seeing as nobody wanted it to begin with and it was just my stopgap solution until I can make a spline chart, I doubt it. Will keep you posted! |
Description
This PR replaces the line chart with a spline chart to make it more pleasant to look at. The only real change is that the chart option is changed from
"line"
to"spline"
, the rest are renaming changes.Old experience:
New experience:
Checklist