Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill color for data explorer box plot #1504

Merged
merged 5 commits into from
Jun 18, 2022
Merged

Conversation

tongyu-microsoft
Copy link
Contributor

@tongyu-microsoft tongyu-microsoft commented Jun 16, 2022

This PR fills the color for data explorer box plot, so it can be consistent with new model overview box plots.

Description

Before:
image

After:
image

For dark mode:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1504 (6b1956b) into main (785422e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1504   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         108      108           
  Lines        5081     5081           
=======================================
  Hits         4449     4449           
  Misses        632      632           
Flag Coverage Δ
unittests 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785422e...6b1956b. Read the comment docs.

@romanlutz
Copy link
Contributor

Do you have a screenshot for dark mode?

1 similar comment
@tongyu-microsoft
Copy link
Contributor Author

Do you have a screenshot for dark mode?

@romanlutz Added screenshot for dark mode in the pr description :D

@romanlutz
Copy link
Contributor

Do you have a screenshot for dark mode?

@romanlutz Added screenshot for dark mode in the pr description :D

Thanks @tongyu-microsoft ! Somehow I had missed this in the model overview as well. This doesn't look great in dark mode. Obviously, I should have caught that earlier 🙁 I took a look at the Fluent UI page but it's not obvious to me which colors change in dark mode to be darker. Any idea?

@tongyu-microsoft
Copy link
Contributor Author

Do you have a screenshot for dark mode?

@romanlutz Added screenshot for dark mode in the pr description :D

Thanks @tongyu-microsoft ! Somehow I had missed this in the model overview as well. This doesn't look great in dark mode. Obviously, I should have caught that earlier 🙁 I took a look at the Fluent UI page but it's not obvious to me which colors change in dark mode to be darker. Any idea?

@romanlutz Updated to a deeper color. How do you think of the new screenshots in the pr description?

@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 16, 2022 23:11
@tongyu-microsoft tongyu-microsoft merged commit 23cabd3 into main Jun 18, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/fillBoxPlot branch June 18, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants