-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill color for data explorer box plot #1504
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1504 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 108 108
Lines 5081 5081
=======================================
Hits 4449 4449
Misses 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Do you have a screenshot for dark mode? |
1 similar comment
@romanlutz Added screenshot for dark mode in the pr description :D |
Thanks @tongyu-microsoft ! Somehow I had missed this in the model overview as well. This doesn't look great in dark mode. Obviously, I should have caught that earlier 🙁 I took a look at the Fluent UI page but it's not obvious to me which colors change in dark mode to be darker. Any idea? |
@romanlutz Updated to a deeper color. How do you think of the new screenshots in the pr description? |
This PR fills the color for data explorer box plot, so it can be consistent with new model overview box plots.
Description
Before:

After:

For dark mode:

Checklist