-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model overview: add cohort selection hint #1496
Merged
romanlutz
merged 7 commits into
main
from
romanlutz/model_overview_feature_selection_hint
Jun 15, 2022
Merged
Model overview: add cohort selection hint #1496
romanlutz
merged 7 commits into
main
from
romanlutz/model_overview_feature_selection_hint
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 87.56% 89.91% +2.35%
==========================================
Files 108 89 -19
Lines 5081 3839 -1242
==========================================
- Hits 4449 3452 -997
+ Misses 632 387 -245
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
xuke444
approved these changes
Jun 14, 2022
imatiach-msft
approved these changes
Jun 14, 2022
1 similar comment
gaugup
approved these changes
Jun 14, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far we didn't give users any kind of hint as to what the cohort selection flyout does or how they are supposed to interact with it:

This PR changes that! Below you see the strings at the top (above the choice group and dropdown). The two pictures show the same strings, but I thought it makes sense to see it in both configurations.
Default without features selected:

With feature selected:

Checklist