Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: add cohort selection hint #1496

Merged
merged 7 commits into from
Jun 15, 2022

Conversation

romanlutz
Copy link
Contributor

Description

So far we didn't give users any kind of hint as to what the cohort selection flyout does or how they are supposed to interact with it:
image

This PR changes that! Below you see the strings at the top (above the choice group and dropdown). The two pictures show the same strings, but I thought it makes sense to see it in both configurations.

Default without features selected:
image

With feature selected:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from xuke444 as a code owner June 13, 2022 22:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #1496 (9cd6053) into main (f9aaf3b) will increase coverage by 2.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   87.56%   89.91%   +2.35%     
==========================================
  Files         108       89      -19     
  Lines        5081     3839    -1242     
==========================================
- Hits         4449     3452     -997     
+ Misses        632      387     -245     
Flag Coverage Δ
unittests 89.91% <ø> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/__version__.py
raiwidgets/raiwidgets/constants.py
raiwidgets/raiwidgets/__init__.py
raiwidgets/raiwidgets/fairness_dashboard.py
raiwidgets/raiwidgets/dashboard.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
raiwidgets/raiwidgets/interfaces.py
...iwidgets/raiwidgets/model_performance_dashboard.py
raiwidgets/raiwidgets/model_analysis_dashboard.py
...iwidgets/raiwidgets/explanation_dashboard_input.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9aaf3b...9cd6053. Read the comment docs.

@romanlutz romanlutz enabled auto-merge (squash) June 14, 2022 14:53
1 similar comment
@romanlutz romanlutz merged commit 753353e into main Jun 15, 2022
@romanlutz romanlutz deleted the romanlutz/model_overview_feature_selection_hint branch June 15, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants