Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: add legend to probability line chart #1492

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

romanlutz
Copy link
Contributor

Description

Adding a legend to the chart:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from xuke444 as a code owner June 13, 2022 18:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #1492 (758cb52) into main (e1f00d9) will increase coverage by 1.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   87.57%   89.30%   +1.73%     
==========================================
  Files         110       38      -72     
  Lines        5093     1617    -3476     
==========================================
- Hits         4460     1444    -3016     
+ Misses        633      173     -460     
Flag Coverage Δ
unittests 89.30% <ø> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onsibleai/responsibleai/serialization_utilities.py
.../responsibleai/_managers/counterfactual_manager.py
raiwidgets/raiwidgets/__init__.py
raiwidgets/raiwidgets/explanation_dashboard.py
...bleai/responsibleai/_tools/causal/causal_config.py
.../responsibleai/_managers/error_analysis_manager.py
responsibleai/responsibleai/_config/__init__.py
...ponsibleai/responsibleai/_tools/shared/__init__.py
...sibleai/responsibleai/_tools/shared/base_result.py
raiwidgets/raiwidgets/constants.py
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f00d9...758cb52. Read the comment docs.

@romanlutz romanlutz enabled auto-merge (squash) June 14, 2022 03:20
@romanlutz romanlutz merged commit 2e339ed into main Jun 14, 2022
@romanlutz romanlutz deleted the romanlutz/model_overview_line_chart_legend branch June 14, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants