Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-ui upgrade] Move components in causality, counterfactuals and dataset-explorer package to fluentui #1481

Merged
merged 9 commits into from
Jun 11, 2022

Conversation

vinuthakaranth
Copy link
Contributor

Description

Move components in causality, counterfactuals and dataset-explorer package to fluentui. No UI changes. Just migration.

Checklist

  • I have added screenshots above for all UI changes. - NA
  • I have added e2e tests for all UI changes. - NA
  • Documentation was updated if it was needed. - NA

Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
@gaugup
Copy link
Contributor

gaugup commented Jun 9, 2022

Any reason why other components are not moved to fluentui?

@vinuthakaranth
Copy link
Contributor Author

Any reason why other components are not moved to fluentui?

I am doing one by one. Breaking upgrade into small PRs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #1481 (116844a) into main (aa62536) will decrease coverage by 2.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   89.91%   87.57%   -2.35%     
==========================================
  Files          90      110      +20     
  Lines        3848     5093    +1245     
==========================================
+ Hits         3460     4460    +1000     
- Misses        388      633     +245     
Flag Coverage Δ
unittests 87.57% <ø> (-2.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/utils.py 100.00% <0.00%> (ø)
...dgets/raiwidgets/error_analysis_dashboard_input.py 69.54% <0.00%> (ø)
raiwidgets/raiwidgets/explanation_constants.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/cohort.py 95.00% <0.00%> (ø)
...iwidgets/raiwidgets/model_performance_dashboard.py 50.00% <0.00%> (ø)
raiwidgets/raiwidgets/constants.py 99.40% <0.00%> (ø)
...iwidgets/raiwidgets/fairness_metric_calculation.py 73.25% <0.00%> (ø)
raiwidgets/raiwidgets/error_analysis_dashboard.py 72.41% <0.00%> (ø)
raiwidgets/raiwidgets/responsibleai_dashboard.py 67.85% <0.00%> (ø)
raiwidgets/raiwidgets/interfaces.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa62536...116844a. Read the comment docs.

1 similar comment
@vinuthakaranth vinuthakaranth enabled auto-merge (squash) June 10, 2022 05:07
@vinuthakaranth vinuthakaranth merged commit 93b9385 into main Jun 11, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/officeUIUpgradeCCD branch June 11, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants