Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse correct prediction by default for individual feature importance #1474

Merged
merged 8 commits into from
Jun 9, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

Since people are focused on the error analysis, it will be more appropriate to by default to show the table with Correct predictions collapsed and only Incorrect predictions expanded.
This PR is to collapse "Correct prediction" by default and show "Incorrect prediction" by default for individual feature importance.

Description

Before:
"Correct prediction" is expanded by default:
image

After:
Collapse "Correct prediction" by default.
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #1474 (cef4cce) into main (12fe368) will increase coverage by 2.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   87.15%   89.48%   +2.32%     
==========================================
  Files         104       84      -20     
  Lines        4897     3652    -1245     
==========================================
- Hits         4268     3268    -1000     
+ Misses        629      384     -245     
Flag Coverage Δ
unittests 89.48% <ø> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/error_analysis_dashboard.py
raiwidgets/raiwidgets/__version__.py
raiwidgets/raiwidgets/fairness_dashboard.py
...iwidgets/raiwidgets/model_performance_dashboard.py
raiwidgets/raiwidgets/cohort.py
raiwidgets/raiwidgets/constants.py
raiwidgets/raiwidgets/model_analysis_dashboard.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
raiwidgets/raiwidgets/explanation_constants.py
raiwidgets/raiwidgets/explanation_dashboard.py
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fe368...cef4cce. Read the comment docs.

2 similar comments
@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 9, 2022 07:13
1 similar comment
@tongyu-microsoft tongyu-microsoft merged commit e79a0a9 into main Jun 9, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/collapseCorrectPrediction branch June 9, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants