-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse correct prediction by default for individual feature importance #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
approved these changes
Jun 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
+ Coverage 87.15% 89.48% +2.32%
==========================================
Files 104 84 -20
Lines 4897 3652 -1245
==========================================
- Hits 4268 3268 -1000
+ Misses 629 384 -245
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
2 similar comments
romanlutz
approved these changes
Jun 8, 2022
…microsoft/responsible-ai-widgets into tongy/collapseCorrectPrediction
1 similar comment
This was referenced Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since people are focused on the error analysis, it will be more appropriate to by default to show the table with Correct predictions collapsed and only Incorrect predictions expanded.
This PR is to collapse "Correct prediction" by default and show "Incorrect prediction" by default for individual feature importance.
Description
Before:

"Correct prediction" is expanded by default:
After:

Collapse "Correct prediction" by default.
Checklist