-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[office-ui upgrade] Move combobox to fluentui #1469
Conversation
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: Ke Xu <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/officeUIUpgrade1
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/officeUIUpgrade2
…olbox into vikarant/officeUIUpgrade2 Signed-off-by: vinutha karanth <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
+ Coverage 87.15% 89.48% +2.32%
==========================================
Files 104 84 -20
Lines 4897 3652 -1245
==========================================
- Hits 4268 3268 -1000
+ Misses 629 384 -245
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a few occurrences in the new model overview as well, right? Perhaps your change is based off of main when it wasn't merged yet?
Thanks Roman. Can you give an example file name where it is missed? also on a side note, I am visiting all left dependencies at once in future. So every dependency will be updated. |
|
* update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * update tslint Signed-off-by: Ke Xu <[email protected]> * checkbox update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Ke Xu <[email protected]>
Description
Moving combobox to fluent UI. No UI changes, Just migration.
Checklist