Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-ui upgrade] Move combobox to fluentui #1469

Merged
merged 9 commits into from
Jun 7, 2022

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Jun 7, 2022

Description

Moving combobox to fluent UI. No UI changes, Just migration.

Checklist

  • I have added screenshots above for all UI changes. -NA
  • I have added e2e tests for all UI changes.-NA
  • Documentation was updated if it was needed.-NA

vinuthakaranth and others added 9 commits June 3, 2022 12:03
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: Ke Xu <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #1469 (cbe5fcf) into main (35284f5) will increase coverage by 2.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
+ Coverage   87.15%   89.48%   +2.32%     
==========================================
  Files         104       84      -20     
  Lines        4897     3652    -1245     
==========================================
- Hits         4268     3268    -1000     
+ Misses        629      384     -245     
Flag Coverage Δ
unittests 89.48% <ø> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/interfaces.py
raiwidgets/raiwidgets/error_analysis_dashboard.py
raiwidgets/raiwidgets/__init__.py
raiwidgets/raiwidgets/utils.py
raiwidgets/raiwidgets/error_analysis_constants.py
raiwidgets/raiwidgets/fairness_dashboard.py
...dgets/raiwidgets/error_analysis_dashboard_input.py
raiwidgets/raiwidgets/responsibleai_dashboard.py
...iwidgets/raiwidgets/model_performance_dashboard.py
raiwidgets/raiwidgets/error_handling.py
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35284f5...cbe5fcf. Read the comment docs.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a few occurrences in the new model overview as well, right? Perhaps your change is based off of main when it wasn't merged yet?

@vinuthakaranth
Copy link
Contributor Author

There should be a few occurrences in the new model overview as well, right? Perhaps your change is based off of main when it wasn't merged yet?

Thanks Roman. Can you give an example file name where it is missed? also on a side note, I am visiting all left dependencies at once in future. So every dependency will be updated.

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) June 7, 2022 19:50
@romanlutz
Copy link
Contributor

There should be a few occurrences in the new model overview as well, right? Perhaps your change is based off of main when it wasn't merged yet?

Thanks Roman. Can you give an example file name where it is missed? also on a side note, I am visiting all left dependencies at once in future. So every dependency will be updated.

https://github.com/microsoft/responsible-ai-toolbox/blob/7fd9b535e485ed9e104b7a3e238e877aa23a2e98/libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ModelOverview.tsx

@vinuthakaranth vinuthakaranth merged commit e54ca69 into main Jun 7, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/officeUIUpgrade2 branch June 7, 2022 20:30
ms-kashyap pushed a commit that referenced this pull request Jun 7, 2022
* update

Signed-off-by: vinutha karanth <[email protected]>

* lintfix

Signed-off-by: vinutha karanth <[email protected]>

* update tslint

Signed-off-by: Ke Xu <[email protected]>

* checkbox update

Signed-off-by: vinutha karanth <[email protected]>

* lintfix

Signed-off-by: vinutha karanth <[email protected]>

* update

Signed-off-by: vinutha karanth <[email protected]>

Co-authored-by: Ke Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants