Fix unable to input decimal point in what if counterfactual feature text field #1459

tongyu-microsoft · 2022-06-01T22:08:33Z

Users are not able to input decimal point in what if counterfactual to update feature value. The root cause is, we check on column value on each update. One example is, when user wants to type in "18.5" and on typing "18.", toNumber() ignores the decimal point, result in user can only input "185" instead of the desired "18.5". The fix is to pass string to this.state.displayedData when the input field value ends with decimal point.

Description

Before:
Unable to input decimal point:

After:

Checklist

I have added screenshots above for all UI changes.
Documentation was updated if it was needed.
New tests were added or changes were manually verified.

* fix error on machines with pyspark installed where passed dataframe is not spark pandas (#1415) * add postbuild branch trigger (#1417) * Fix causal UI strings according to classification/regression tasks (#1419) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Fix description for model overview (#1425) * fix description for model overview * keep new description for new model overview * fix failing to create error report when filter_features is empty list (#1421) * filter out missing values from what if dropdown to prevent explanation dashboard from crashing (#1418) * Remove |Set Value| blurb in case it is not availble in counterfactual panel (#1426) Signed-off-by: Gaurav Gupta <[email protected]> * Add y-axis description to counterfactual feature importance chart (#1423) Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * Add the user class name to causal UI strings (#1422) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Add the user class name to causal UI strings Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * fix math.min / max for array size more than 10^7 (#1427) Signed-off-by: Ke Xu <[email protected]> * upgrade pytest and lightgbm to try to fix random pytest segfault test failures (#1424) s * fix flaky notebook causing build failures by adding retry logic (#1431) * Upper bound SciKit-Learn to address freeze in causal (#1432)  ## Description Replaces #1429 to address #1430 . Causal analysis is getting stuck with the latest release of SciKit-Learn. This contains: - Test case which gets stuck with SciKit-Learn 1.1.0 - Upper bound on SciKit-Learn in `requirements.txt` ## Checklist  - [x] I have added screenshots above for all UI changes. - [x] Documentation was updated if it was needed. - [x] New tests were added or changes were manually verified. Signed-off-by: Richard Edgar <[email protected]> * fix dependency chart axis updating with incorrect values in explanation dashboard (#1437) * fix codecov and widget test screenshot uploads (#1428) * release raiwidgets and responsibleai v0.18.2 (#1439) * fix (#1441) Signed-off-by: vinutha karanth <[email protected]> * Fix cohort name conflict and not run few tests for AML (#1442) * fix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * Few e2e tests changes to accommodate AML static tests (#1445) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * Fix locators logic for string features - data explorer and model statistics components (#1446) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * Add more unittests RAI dashboard input class (#1448) * Add unit tests for ResponsibleAIDashboardInput Signed-off-by: Gaurav Gupta <[email protected]> * Add more tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix imports Signed-off-by: Gaurav Gupta <[email protected]> * Address code review comments Signed-off-by: Gaurav Gupta <[email protected]> * Update the way to get the length of elements obtained in e2e tests (#1450) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * skip what-if create tests for AML Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> Co-authored-by: Richard Edgar <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]>

…ategorical')" (#1452) * fix error on machines with pyspark installed where passed dataframe is not spark pandas (#1415) * add postbuild branch trigger (#1417) * Fix causal UI strings according to classification/regression tasks (#1419) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Fix description for model overview (#1425) * fix description for model overview * keep new description for new model overview * fix failing to create error report when filter_features is empty list (#1421) * filter out missing values from what if dropdown to prevent explanation dashboard from crashing (#1418) * Remove |Set Value| blurb in case it is not availble in counterfactual panel (#1426) Signed-off-by: Gaurav Gupta <[email protected]> * Add y-axis description to counterfactual feature importance chart (#1423) Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * Add the user class name to causal UI strings (#1422) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Add the user class name to causal UI strings Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * fix math.min / max for array size more than 10^7 (#1427) Signed-off-by: Ke Xu <[email protected]> * upgrade pytest and lightgbm to try to fix random pytest segfault test failures (#1424) s * fix flaky notebook causing build failures by adding retry logic (#1431) * Upper bound SciKit-Learn to address freeze in causal (#1432)  ## Description Replaces #1429 to address #1430 . Causal analysis is getting stuck with the latest release of SciKit-Learn. This contains: - Test case which gets stuck with SciKit-Learn 1.1.0 - Upper bound on SciKit-Learn in `requirements.txt` ## Checklist  - [x] I have added screenshots above for all UI changes. - [x] Documentation was updated if it was needed. - [x] New tests were added or changes were manually verified. Signed-off-by: Richard Edgar <[email protected]> * fix dependency chart axis updating with incorrect values in explanation dashboard (#1437) * fix codecov and widget test screenshot uploads (#1428) * release raiwidgets and responsibleai v0.18.2 (#1439) * fix (#1441) Signed-off-by: vinutha karanth <[email protected]> * Fix cohort name conflict and not run few tests for AML (#1442) * fix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * Few e2e tests changes to accommodate AML static tests (#1445) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * Fix locators logic for string features - data explorer and model statistics components (#1446) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * Add more unittests RAI dashboard input class (#1448) * Add unit tests for ResponsibleAIDashboardInput Signed-off-by: Gaurav Gupta <[email protected]> * Add more tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix imports Signed-off-by: Gaurav Gupta <[email protected]> * Address code review comments Signed-off-by: Gaurav Gupta <[email protected]> * more update Signed-off-by: vinutha karanth <[email protected]> * Update the way to get the length of elements obtained in e2e tests (#1450) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * skip what-if create tests for AML Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: Roman Lutz <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> Co-authored-by: Richard Edgar <[email protected]>

codecov-commenter · 2022-06-01T22:11:45Z

Codecov Report

Merging #1459 (2f29701) into main (93b9385) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files         110      110           
  Lines        5093     5093           
=======================================
  Hits         4460     4460           
  Misses        633      633

Flag	Coverage Δ
unittests	`87.57% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b9385...2f29701. Read the comment docs.

libs/counterfactuals/src/lib/CounterfactualList.tsx

…t/responsible-ai-widgets into tongy/fractionErrorInCF

github-actions · 2022-06-01T23:13:12Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-01T23:18:00Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-02T00:00:20Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-02T00:11:18Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

gaugup · 2022-06-02T00:23:18Z

Can you please capture this change in the e2e tests?

libs/counterfactuals/src/lib/CounterfactualList.tsx

…el (#1458) * fix error on machines with pyspark installed where passed dataframe is not spark pandas (#1415) * add postbuild branch trigger (#1417) * Fix causal UI strings according to classification/regression tasks (#1419) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Fix description for model overview (#1425) * fix description for model overview * keep new description for new model overview * fix failing to create error report when filter_features is empty list (#1421) * filter out missing values from what if dropdown to prevent explanation dashboard from crashing (#1418) * Remove |Set Value| blurb in case it is not availble in counterfactual panel (#1426) Signed-off-by: Gaurav Gupta <[email protected]> * Add y-axis description to counterfactual feature importance chart (#1423) Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * Add the user class name to causal UI strings (#1422) * Fix causal UI strings according to classification/regression tasks Signed-off-by: Gaurav Gupta <[email protected]> * Fix lint error Signed-off-by: Gaurav Gupta <[email protected]> * Fix UI test Signed-off-by: Gaurav Gupta <[email protected]> * Add the user class name to causal UI strings Signed-off-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> * fix math.min / max for array size more than 10^7 (#1427) Signed-off-by: Ke Xu <[email protected]> * upgrade pytest and lightgbm to try to fix random pytest segfault test failures (#1424) s * fix flaky notebook causing build failures by adding retry logic (#1431) * Upper bound SciKit-Learn to address freeze in causal (#1432)  ## Description Replaces #1429 to address #1430 . Causal analysis is getting stuck with the latest release of SciKit-Learn. This contains: - Test case which gets stuck with SciKit-Learn 1.1.0 - Upper bound on SciKit-Learn in `requirements.txt` ## Checklist  - [x] I have added screenshots above for all UI changes. - [x] Documentation was updated if it was needed. - [x] New tests were added or changes were manually verified. Signed-off-by: Richard Edgar <[email protected]> * fix dependency chart axis updating with incorrect values in explanation dashboard (#1437) * fix codecov and widget test screenshot uploads (#1428) * release raiwidgets and responsibleai v0.18.2 (#1439) * fix (#1441) Signed-off-by: vinutha karanth <[email protected]> * Fix cohort name conflict and not run few tests for AML (#1442) * fix Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * Few e2e tests changes to accommodate AML static tests (#1445) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * Fix locators logic for string features - data explorer and model statistics components (#1446) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * fix Signed-off-by: vinutha karanth <[email protected]> * Add more unittests RAI dashboard input class (#1448) * Add unit tests for ResponsibleAIDashboardInput Signed-off-by: Gaurav Gupta <[email protected]> * Add more tests Signed-off-by: Gaurav Gupta <[email protected]> * Fix imports Signed-off-by: Gaurav Gupta <[email protected]> * Address code review comments Signed-off-by: Gaurav Gupta <[email protected]> * Update the way to get the length of elements obtained in e2e tests (#1450) * update Signed-off-by: vinutha karanth <[email protected]> * update Signed-off-by: vinutha karanth <[email protected]> * skip what-if create tests for AML Signed-off-by: vinutha karanth <[email protected]> * update cf predicted class to non-editable text Co-authored-by: Ilya Matiach <[email protected]> Co-authored-by: Roman Lutz <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]> Co-authored-by: xuke444 <[email protected]> Co-authored-by: Richard Edgar <[email protected]> Co-authored-by: Vinutha Karanth <[email protected]>

tongyu-microsoft · 2022-06-02T21:26:13Z

Add E2E test for targetClass in describeWhatIfCreate.ts

…rorInCF

github-actions · 2022-06-03T19:31:02Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-03T19:55:52Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-07T00:34:57Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

tongyu-microsoft · 2022-06-08T18:03:44Z

Can you please capture this change in the e2e tests?

Tests are added

tongyu-microsoft · 2022-06-08T18:03:58Z

Add E2E test for targetClass in describeWhatIfCreate.ts

Tests are added

github-actions · 2022-06-08T19:17:09Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-08T19:28:26Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-11T00:32:23Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-11T00:41:34Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

github-actions · 2022-06-11T01:28:36Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

…t/responsible-ai-widgets into tongy/fractionErrorInCF

github-actions · 2022-06-11T05:05:13Z

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/tongy/fractionErrorInCF/dashboard/index.html

romanlutz and others added 3 commits May 26, 2022 18:11

fix unable to input decimal point

726befe

tongyu-microsoft requested review from romanlutz, vinuthakaranth and xuke444 as code owners June 1, 2022 22:08

Merge branch 'postbuild' into tongy/fractionErrorInCF

71a9e52

gaugup reviewed Jun 1, 2022

View reviewed changes

libs/counterfactuals/src/lib/CounterfactualList.tsx Show resolved Hide resolved

tongyu-microsoft added 3 commits June 1, 2022 16:03

add displayedData to make sure prediction call works

1619cdf

Merge branch 'tongy/fractionErrorInCF' of https://github.com/microsof…

231199c

…t/responsible-ai-widgets into tongy/fractionErrorInCF

update comment

6ca6153

romanlutz reviewed Jun 2, 2022

View reviewed changes

libs/counterfactuals/src/lib/CounterfactualList.tsx Outdated Show resolved Hide resolved

imatiach-msft approved these changes Jun 2, 2022

View reviewed changes

tongyu-microsoft mentioned this pull request Jun 2, 2022

Update predicted class value to uneditable text in counterfactual panel #1458

Merged

3 tasks

tongyu-microsoft added 4 commits June 2, 2022 14:53

Merge remote-tracking branch 'origin/main' into tongy/fractionErrorInCF

363627b

Merge remote-tracking branch 'origin/postbuild' into tongy/fractionEr…

51e7ce5

…rorInCF

remove unused change

11391ec

remove line break

1793680

tongyu-microsoft changed the base branch from postbuild to main June 6, 2022 18:57

tongyu-microsoft changed the base branch from main to postbuild June 6, 2022 18:58

tongyu-microsoft changed the base branch from postbuild to main June 6, 2022 23:23

Merge remote-tracking branch 'origin/main' into tongy/fractionErrorInCF

fac76ce

add e2e tests

4096d0f

Merge branch 'main' into tongy/fractionErrorInCF

0f305e0

tongyu-microsoft and others added 4 commits June 9, 2022 16:09

Merge remote-tracking branch 'origin/main' into tongy/fractionErrorInCF

2437499

update e2e

8b57850

Merge branch 'main' into tongy/fractionErrorInCF

fdf62ba

Merge branch 'main' into tongy/fractionErrorInCF

08c4eae

tongyu-microsoft added 2 commits June 10, 2022 20:56

fix flaky test

60e3ccd

Merge branch 'tongy/fractionErrorInCF' of https://github.com/microsof…

2f29701

…t/responsible-ai-widgets into tongy/fractionErrorInCF

romanlutz approved these changes Jun 13, 2022

View reviewed changes

tongyu-microsoft merged commit 9342c46 into main Jun 13, 2022

tongyu-microsoft deleted the tongy/fractionErrorInCF branch June 13, 2022 17:09

imatiach-msft mentioned this pull request Jul 18, 2022

release raiwidgets and responsibleai 0.20.0 #1563

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix unable to input decimal point in what if counterfactual feature text field #1459

Fix unable to input decimal point in what if counterfactual feature text field #1459

tongyu-microsoft commented Jun 1, 2022 •

edited

Loading

codecov-commenter commented Jun 1, 2022 •

edited

Loading

github-actions bot commented Jun 1, 2022

github-actions bot commented Jun 1, 2022

github-actions bot commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

gaugup commented Jun 2, 2022

tongyu-microsoft commented Jun 2, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 7, 2022

tongyu-microsoft commented Jun 8, 2022

tongyu-microsoft commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

Fix unable to input decimal point in what if counterfactual feature text field #1459

Fix unable to input decimal point in what if counterfactual feature text field #1459

Conversation

tongyu-microsoft commented Jun 1, 2022 • edited Loading

Description

Checklist

codecov-commenter commented Jun 1, 2022 • edited Loading

Codecov Report

github-actions bot commented Jun 1, 2022

github-actions bot commented Jun 1, 2022

github-actions bot commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

gaugup commented Jun 2, 2022

tongyu-microsoft commented Jun 2, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 7, 2022

tongyu-microsoft commented Jun 8, 2022

tongyu-microsoft commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

github-actions bot commented Jun 8, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

github-actions bot commented Jun 11, 2022

tongyu-microsoft commented Jun 1, 2022 •

edited

Loading

codecov-commenter commented Jun 1, 2022 •

edited

Loading