Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taking dependency on is_classifier() method and SKLearn constants class from raiutils #1289

Merged
merged 10 commits into from
Jun 15, 2022
Merged

Taking dependency on is_classifier() method and SKLearn constants class from raiutils #1289

merged 10 commits into from
Jun 15, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Mar 23, 2022 •
edited
Loading

Description

Taking dependency on is_classifier() method and SKLearn method constants class from raiutils. This helps reduce some duplicate code in raiwidgets and responsibleai.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

romanlutz
romanlutz approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @imatiach-msft 's comments. Thanks for adding this @gaugup !

@gaugup gaugup mentioned this pull request Jun 3, 2022
Merged
18 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #1289 (9b55b0d) into main (1419cb3) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1289      +/-   ##
==========================================
- Coverage   87.57%   87.56%   -0.01%     
==========================================
  Files         110      108       -2     
  Lines        5093     5081      -12     
==========================================
- Hits         4460     4449      -11     
+ Misses        633      632       -1
Flag Coverage Δ
unittests 87.56% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/_internal/constants.py 100.00% <ø> (ø)
...sibleai/responsibleai/rai_insights/rai_insights.py 72.50% <66.66%> (ø)
...dgets/raiwidgets/error_analysis_dashboard_input.py 69.54% <100.00%> (ø)
...iwidgets/raiwidgets/explanation_dashboard_input.py 60.13% <100.00%> (ø)
...idgets/raiwidgets/responsibleai_dashboard_input.py 94.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1419cb3...9b55b0d. Read the comment docs.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@gaugup gaugup changed the title Moving _is_classifier() method and SKLearn class to raiutils Taking dependecy on is_classifier() method and SKLearn constants class from raiutils Jun 10, 2022
@gaugup gaugup changed the title Taking dependecy on is_classifier() method and SKLearn constants class from raiutils Taking dependency on is_classifier() method and SKLearn constants class from raiutils Jun 10, 2022
@gaugup gaugup changed the title Taking dependency on is_classifier() method and SKLearn constants class from raiutils Taking dependency on is_classifier() method and SKLearn constants class from raiutils Jun 10, 2022
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@gaugup gaugup enabled auto-merge (squash) June 14, 2022 00:57
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/RefactorMoreUtilitiesInRAIUtils/dashboard/index.html

@gaugup gaugup merged commit bcd90dd into main Jun 15, 2022
@gaugup gaugup deleted the gaugup/RefactorMoreUtilitiesInRAIUtils branch June 15, 2022 00:37
@imatiach-msft imatiach-msft mentioned this pull request Jul 18, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

@riedgar-ms riedgar-ms Awaiting requested review from riedgar-ms

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@kicha0 kicha0 Awaiting requested review from kicha0 kicha0 is a code owner

@zhb000 zhb000 Awaiting requested review from zhb000

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaugup @codecov-commenter @romanlutz @imatiach-msft @raghavthind2005