fix tree api being called twice on initial load due to uninitialized context being used #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During profiling, I found that /tree was still being called twice on initial load of error analysis component, hurting performance - specifically for large data. This was due to context being used incorrectly in the constructor. For more information, please see:
facebook/react#6598
This is the correct way to use context in constructor. Due to uninitialized context being used in constructor, we were calling the tree API again in componentDidUpdate because the code thought there was a state change.
Areas changed
npm packages changed:
Python packages changed:
Tests
Screenshots (if appropriate):
Documentation: