Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now-unncessary GitHub Actions image workaround #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

achamayou
Copy link
Member

Resolved by actions/runner-images#9679, and became irrelevant since actions/runner-images#10636 too.

@achamayou achamayou requested a review from matajoh January 21, 2025 10:30
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achamayou
Copy link
Member Author

The rust wrapper build is broken for unrelated reasons, there's a call to setError that looks risky:

https://github.com/microsoft/rego-cpp/blob/main/src/rego_c.cc#L120

https://github.com/microsoft/rego-cpp/blob/main/src/rego_c.cc#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants