Skip to content

Enabled Image.prefetch for UWP #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erictraut merged 1 commit into from
Jul 18, 2017
Merged

Enabled Image.prefetch for UWP #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/native-common/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,11 @@ export class Image extends React.Component<Types.ImageProps, {}> {
static prefetch(url: string): SyncTasks.Promise<boolean> {
const defer = SyncTasks.Defer<boolean>();

// TODO: #694125 Remove conditional after RN UWP supports prefetch
// https://github.com/ReactWindows/react-native-windows/issues/366
if (RN.Platform.OS !== 'windows') {
RN.Image.prefetch(url).then(value => {
defer.resolve(value);
}).catch(error => {
defer.reject(error);
});
}
RN.Image.prefetch(url).then(value => {
defer.resolve(value);
}).catch(error => {
defer.reject(error);
});

return defer.promise();
}
Expand Down