Skip to content

Conversation

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 29, 2022

Description

This PR updates RNW to build with (and require) Visual Studio 2022. This includes upgrading the Microsoft.ReactNative.Managed.CodeGen project to .NET 6.0

This PR does not change the minimum / target Windows SDK versions for RNW or RNW apps.

This PR does not change the language versions of C++ (17) and C# (8.0) used.

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Why

Visual Studio 2022 is the currently supported version of Visual Studio and what is available to download without an MSDN subscription to access older versions. As Visual Studio 2019 support is reduced/deprecated, we need to migrate.

Closes #8750
Closes #9499
Closes #10130

What

What's changed:

  • All VS project files have been updated to require a minimum of VS 2022 (aka version 17.0).
    • NuGet-based dependencies that are tied to VS version have been upgraded.
  • The Microsoft.ReactNative.Managed.CodeGen project has been updated to .NET 6.0
    • The snapshots for the codegen tests have been updated to pass
  • The E2E Test app has been updated to the latest version of react-native-xaml (needed to fix build issues)
    • Snapshots for E2E tests have been updated to pass

Screenshots

N/A

Testing

Builds and tests All tests

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Apr 29, 2022

CLA assistant check
All CLA requirements met.

@jonthysell jonthysell force-pushed the vs2022 branch 2 times, most recently from 9cedb42 to 65f2216 Compare August 4, 2022 21:58
@jonthysell jonthysell force-pushed the vs2022 branch 2 times, most recently from 9a12a1f to 48477aa Compare October 11, 2022 00:13
@jonthysell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This PR updates all projects in the repo to build with Visual Studio 2022.
@jonthysell jonthysell added Area: Test Infrastructure Breaking Change This PR will break existing apps and should be part of the known breaking changes for the release Area: Dependencies labels Oct 13, 2022
@jonthysell jonthysell marked this pull request as ready for review October 13, 2022 22:35
@jonthysell jonthysell requested a review from a team as a code owner October 13, 2022 22:35
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jonthysell jonthysell merged commit 5885ee4 into microsoft:main Oct 31, 2022
@jonthysell jonthysell deleted the vs2022 branch October 31, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Build Infrastructure Area: Dependencies Area: Developer Experience Area: Test Infrastructure Breaking Change This PR will break existing apps and should be part of the known breaking changes for the release

Projects

None yet

4 participants