feat(Shared): Migrate Image#882
Closed
kevinvangelder wants to merge 35 commits intomicrosoft:masterfrom
Closed
Conversation
* Fixed some crashes when starting due to differences between Net46 and UWP * Converted Net46 Dialogs to be shown as modeless to ensure execution can continue (e.g. progress dialog)
…sign data file/classes * Added ScrollViewer to RedBoxDialog
…tures since KeyDown events are not reaching RootView without making the RootView Focusable and explictly setting focus on it... * Styled the Developer Options dialog... * Fixed crash when saving application settings via the developer options dialog
…nsured the Focus was applied to it by the ReactPage OnCreate * Restore support for keyboard accelerators to bring up dev options, changed dev option accelerators to match other React Native Clients. * Fix issue in getting the correct bundle path * Added support to copy the ChakraCore DLL to the Playground Net46 output directory
rozele
reviewed
Nov 16, 2016
| var waitHandle = new AutoResetEvent(false); | ||
| var json = default(JObject); | ||
| bool websocketFailedCalled = false; | ||
|
|
Contributor
There was a problem hiding this comment.
Take a look at a bunch of the comments from the ScrollView review, same stuff needs to be cleaned up here.
Contributor
|
🕐 |
kevinvangelder
commented
Nov 17, 2016
| @@ -1,4 +1,4 @@ | |||
| using Newtonsoft.Json.Linq; | |||
| using Newtonsoft.Json.Linq; | |||
Contributor
Author
|
Replaced by #895. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.