Implement Net46 Playground Application #868

pre10der89 · 2016-11-09T22:43:57Z

Implement the Net46 React Native Windows application.

…-windows

…ation...

…on's shell...

…-windows

* Fixed some crashes when starting due to differences between Net46 and UWP * Converted Net46 Dialogs to be shown as modeless to ensure execution can continue (e.g. progress dialog)

…indows into playground-net46

…sign data file/classes * Added ScrollViewer to RedBoxDialog

…tures since KeyDown events are not reaching RootView without making the RootView Focusable and explictly setting focus on it... * Styled the Developer Options dialog... * Fixed crash when saving application settings via the developer options dialog

…-windows

…indows into playground-net46

…nsured the Focus was applied to it by the ReactPage OnCreate * Restore support for keyboard accelerators to bring up dev options, changed dev option accelerators to match other React Native Clients. * Fix issue in getting the correct bundle path * Added support to copy the ChakraCore DLL to the Playground Net46 output directory

…-windows

…indows into playground-net46

…t-native-windows into playground-net46

…odule

rozele · 2016-11-09T23:05:34Z

ReactWindows/ReactNative.sln

+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Playground.Net46", "Playground.Net46\Playground.Net46.csproj", "{7AB3A24A-D5D9-479F-8E12-22213DD40D3F}"
+	ProjectSection(ProjectDependencies) = postProject
+		{E02ED054-4FB2-4EEB-8835-36A5E542E368} = {E02ED054-4FB2-4EEB-8835-36A5E542E368}
+	EndProjectSection


What is this for? #Closed

I believe this is the addition of the new project for Playground.Net46 #Closed

rozele · 2016-11-09T23:11:20Z

ReactWindows/Playground.Net46/PlaygroundBootstrapper.cs

+
+namespace Playground.Net46
+{
+    public sealed class PlaygroundBootstrapper : ReactNativeBootstrapper


PlaygroundBootstrapper [](start = 24, length = 22)

Can we cleanup the bootstrapper stuff into a "minimalist" setup for getting the app running.

I have removed all bootstrapper related code from the Playground.Net46 and have gone with a more minimalist approach similar to Playground

…-windows

pre10der89 · 2016-11-11T00:12:52Z

ReactWindows/ReactNative.Net46/ReactPage.cs

+            //    return this.ReactInstanceManager.DisposeAsync();
+            //}
+
+            return this.ReactInstanceManager.DisposeAsync();


The goal here was to check if the reactInstanceManager has been created before trying to Dispose it... The return statement is not correct because it means that we may be creating the object only to dispose of it (clearly not what we want)...

The commented out code is the solution to the above problem, but I'm not sure what the correct return statement is for the case when IsValueCreated is false.

The method is not marked as "async" and we are not awaiting on the DisposeAsync. Should we mark the dispose async and await on the DisposeAsync?

…indows into playground-net46

…'s show operations...

rozele · 2016-11-11T21:14:47Z

ReactWindows/Playground.Net46/App.xaml.cs

+        {
+        }
+
+        protected override void OnStartup(StartupEventArgs e)


OnStartup [](start = 32, length = 9)

add docs to protected methods #Closed

rozele · 2016-11-11T21:14:57Z

ReactWindows/Playground.Net46/App.xaml.cs

+        protected override void OnActivated(EventArgs e)
+        {
+            base.OnActivated(e);
+        }


Delete this.

rozele · 2016-11-11T21:18:28Z

ReactWindows/ReactNative.Net46/ReactNative.Net46.csproj

@@ -17,7 +17,9 @@
    <OutputPath>bin\x86\Debug\</OutputPath>
    <DefineConstants>DEBUG;NET46</DefineConstants>
    <DocumentationFile>bin\x86\Debug\ReactNative.Net46.XML</DocumentationFile>
-    <DebugType>none</DebugType>
+    <DebugType>pdbonly</DebugType>


pdbonly [](start = 15, length = 7)

Do this for all debug builds? #Closed

rozele · 2016-11-11T21:20:42Z

ReactWindows/ReactNative.Net46/ReactPage.cs

        {
-            RootView.Background = (Brush)Application.Current.Resources["ApplicationPageBackgroundThemeBrush"];
+            RootView.Background = SystemColors.WindowBrush;



Remove this.

rozele · 2016-11-11T21:21:59Z

ReactWindows/ReactNative.Net46/ReactPage.cs

        {
-            if (!string.IsNullOrEmpty(arguments))
+            if (arguments == null) return;


{ } #Closed

rozele · 2016-11-11T21:22:26Z

ReactWindows/ReactNative.Net46/ReactPage.cs

+                return reactInstanceManager;
+            });
+
+            this._rootView = new Lazy<ReactRootView>(() =>


this [](start = 12, length = 4)

Remove this if you want to :-) #Closed

I am going to remove all this. except the one where I'm referencing dispatcher from the Page base class where I'll use base.Dispatcher to make it clear it is using a class member not from the immediate class..

rozele · 2016-11-11T21:22:54Z

ReactWindows/ReactNative.Net46/Bridge/DispatcherHelpers.cs

@@ -5,8 +5,43 @@

 namespace ReactNative.Bridge
 {
-    static class DispatcherHelpers
+    internal static class DispatcherHelpers


internal by default #Closed

rozele · 2016-11-11T21:24:26Z

ReactWindows/ReactNative.Net46/Bridge/DispatcherHelpers.cs

+                {
+                    throw new InvalidOperationException("Dispatcher has not been set");
+                }
+


Take this, insert into private method called AssertDispatcherSet, apply below.

rozele · 2016-11-11T21:24:53Z

ReactWindows/ReactNative.Net46/Bridge/DispatcherHelpers.cs

@@ -17,12 +52,17 @@ public static void AssertOnDispatcher()

        public static bool IsOnDispatcher()
        {
-            return Thread.CurrentThread == Dispatcher.CurrentDispatcher.Thread;
+            if (CurrentDispatcher == null)
+            {


AssertDispatcherSet #Closed

rozele · 2016-11-11T21:25:05Z

ReactWindows/ReactNative.Net46/Bridge/DispatcherHelpers.cs

        }

        public static async void RunOnDispatcher(Action action)
        {
-            await Dispatcher.CurrentDispatcher.InvokeAsync(action).Task.ConfigureAwait(false);
+            await CurrentDispatcher.InvokeAsync(action).Task.ConfigureAwait(false);


CurrentDispatcher [](start = 18, length = 17)

Use is AssertDispatcherSet #Closed

rozele · 2016-11-11T21:28:33Z

ReactWindows/ReactNative.Net46/Modules/WebSocket/WebSocketModule.cs

+        {
+            if (options != null && options.ContainsKey("origin"))
+            {
+                throw new NotImplementedException(/* TODO: (#253) */);


Double check if you guys can implement this.

rozele · 2016-11-11T21:30:28Z

ReactWindows/ReactNative.Net46/UIManager/UIManagerModule.cs

@@ -42,6 +42,8 @@ public partial class UIManagerModule : ReactContextNativeModuleBase, ILifecycleE
                throw new ArgumentNullException(nameof(viewManagers));
            if (uiImplementation == null)
                throw new ArgumentNullException(nameof(uiImplementation));
+            if ( window == null )


[](start = 16, length = 1)

No space after () #Closed

rozele · 2016-11-11T21:31:49Z

ReactWindows/ReactNative.Net46/Views/Text/ReactTextViewManager.cs

@@ -46,7 +46,7 @@ public void SetColor(RichTextBox view, uint? color)
        /// <param name="view">The view.</param>
        /// <param name="selectable">A flag indicating whether or not the text is selectable.</param>
        [ReactProp("selectable")]
-        public void SetSelectable(RichTextBox view, bool selectable)
+        public void SetSelectable(TextBlock view, bool selectable)
        {
            // ToDo: Manually control selectable
        }


throw NotImplementedException() #Closed

rozele · 2016-11-11T21:37:19Z

ReactWindows/ReactNative.Net46.Tests/Modules/NetInfo/NetInfoModuleTests.cs

        public void NetInfoModule_Event()
        {
+            SetDispatcherForTest();
+


Nothing about NetInfo should require a dispatcher.

The NetInfo tests themselves are calling OnResume, which will assert on the dispatcher availability... Leaving code that sets the dispatcher ahead of the test execution...

rozele · 2016-11-11T21:37:45Z

ReactWindows/ReactNative.Shared/Bridge/NativeModuleRegistry.cs

@@ -175,6 +175,8 @@ public void Invoke(IReactInstance reactInstance, int methodId, JArray parameters

            public void WriteModuleDescription(JsonWriter writer)
            {
+                if (Target == null) throw new NullReferenceException("Target");
+


This should never be null.

rozele · 2016-11-11T21:40:05Z

ReactWindows/ReactNative.Shared/DevSupport/DevInternalSettings.cs

@@ -125,6 +125,7 @@ public bool IsReloadOnJavaScriptChangeEnabled
            }
        }

+        //TODO: Implement an abstraction or static helper to save settings based on the platform... The GetSetting and SetSetting methods or their contents are replicated elsewhere...
        private T GetSetting<T>(string key, T defaultValue)


Can we add a GitHub issue instead of a TODO, can leave a shorter TODO with reference to GitHub issue number

rozele · 2016-11-11T21:45:36Z

ReactWindows/ReactNative.Shared/DevSupport/DevInternalSettings.cs

-            var values = ConfigurationManager.AppSettings;
-            if (values[key] == null)
+            var configFile = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.None);
+            var settings = configFile.AppSettings.Settings;


Let's just be readonly, either this can be a no-op or it can just set some internal in-memory dictionary.

I have implemented a simple Dictionary to store these values in memory... The settings will not be persisted across application instances...

rozele · 2016-11-11T21:48:23Z

ReactWindows/ReactNative.Shared/Modules/I18N/I18NUtil.cs

+            var values = ApplicationData.Current.LocalSettings.Values;
+            values[key] = value;
+#else
+            var configFile = ConfigurationManager.OpenExeConfiguration(ConfigurationUserLevel.None);


OpenExeConfiguration [](start = 50, length = 20)

In-memory dictionary instead of using ConfigurationManager

…-windows

…indows into playground-net46

rozele · 2016-11-15T18:37:07Z

pre10der89 and others added 28 commits October 31, 2016 09:49

Syncing with upstream

88370b1

Merge branch 'master' of https://github.com/ReactWindows/react-native…

f84414a

…-windows

Merge branch 'master' of https://github.com/ReactWindows/react-native…

03ced95

…-windows

Merge branch 'master' of https://github.com/ReactWindows/react-native…

06f707e

…-windows

Merge branch 'master' of https://github.com/ReactWindows/react-native…

4a27072

…-windows

Adding shell/MainReactPackage to ReactNative.Net46

95e155d

Adding Playground.Net46 WPF application with basic ReactNative integr…

a468c89

…ation...

Added a bootstrapper for initializing the ReactPage and the applicati…

d0665a7

…on's shell...

Merge branch 'master' of https://github.com/ReactWindows/react-native…

32a32a8

…-windows

Reverting the Examples to the previous version

0182bf4

Merge branch 'master' of https://github.com/ReactWindows/react-native…

c14d959

…-windows

* Restyling Net46 RedBoxDialog and ProgressDialog to fit WPF styling...

08f2fed

* Fixed some crashes when starting due to differences between Net46 and UWP * Converted Net46 Dialogs to be shown as modeless to ensure execution can continue (e.g. progress dialog)

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

f9f14d2

…indows into playground-net46

* Moving Progress Design Data to its own file... Renaming existing de…

20e5573

…sign data file/classes * Added ScrollViewer to RedBoxDialog

Merge branch 'master' of https://github.com/ReactWindows/react-native…

826f389

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

d882809

…indows into playground-net46

Fixing random issues everywhere...

f30bd7f

Fixing Touch point issues

d3ca586

Final debugging of Playground.Net46 App

7cdbd8b

code cleanup

6867174

upgraded nuget package and implemented websocket module

de556c9

Merge branch 'master' of https://github.com/ReactWindows/react-native…

63f0152

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

496aebc

…indows into playground-net46

Merge branch 'playground-net46' of https://github.com/pre10der89/reac…

4c2514f

…t-native-windows into playground-net46

Fixing failing tests on dispatcher null reference

42ea822

Migrated WebSocketModuleTests to Shared.Tests, Fixed Net46 WebSocketM…

e9ae10d

…odule

rozele reviewed Nov 9, 2016

View reviewed changes

Merge branch 'master' of https://github.com/ReactWindows/react-native…

ac60c27

…-windows

pre10der89 commented Nov 11, 2016

View reviewed changes

pre10der89 added 3 commits November 10, 2016 16:13

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

5331481

…indows into playground-net46

Fixing race condition between the main window and the progress dialog…

7a3a24a

…'s show operations...

Correcting incorrect comment

0350892

rozele reviewed Nov 11, 2016

View reviewed changes

pre10der89 added 3 commits November 14, 2016 10:19

Adding fixes/changes from Pull Request code review...

346eda9

Merge branch 'master' of https://github.com/ReactWindows/react-native…

9947873

…-windows

Merge branch 'master' of https://github.com/pre10der89/react-native-w…

5e1b14d

…indows into playground-net46

rozele approved these changes Nov 15, 2016

View reviewed changes

rozele merged commit 8bf64e1 into microsoft:master Nov 15, 2016

pre10der89 deleted the playground-net46 branch November 15, 2016 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Net46 Playground Application #868

Implement Net46 Playground Application #868

pre10der89 commented Nov 9, 2016

rozele Nov 9, 2016 •

edited

Loading

pre10der89 Nov 10, 2016 •

edited by rozele

Loading

rozele Nov 9, 2016

pre10der89 Nov 10, 2016

pre10der89 Nov 11, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

pre10der89 Nov 12, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016

pre10der89 Nov 12, 2016

rozele Nov 11, 2016

rozele Nov 11, 2016

rozele Nov 11, 2016

pre10der89 Nov 14, 2016

rozele Nov 11, 2016

rozele commented Nov 15, 2016

Implement Net46 Playground Application #868

Implement Net46 Playground Application #868

Conversation

pre10der89 commented Nov 9, 2016

rozele Nov 9, 2016 • edited Loading

Choose a reason for hiding this comment

pre10der89 Nov 10, 2016 • edited by rozele Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

rozele Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rozele commented Nov 15, 2016

rozele Nov 9, 2016 •

edited

Loading

pre10der89 Nov 10, 2016 •

edited by rozele

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading

rozele Nov 11, 2016 •

edited

Loading