Skip to content

Use babel-plugin-inline-view-configs to increase verification of viewmanagers #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6 commits merged into from
Jul 7, 2020
Merged

Use babel-plugin-inline-view-configs to increase verification of viewmanagers #5431

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bdf59a1
Use babel-plugin-inline-view-configs to verify viewmanager props matc…
acoates-ms Jul 6, 2020
b9a59e0
Merge remote-tracking branch 'upstream/master' into inlineviewconfigs
acoates-ms Jul 6, 2020
888663c
Merge remote-tracking branch 'upstream/master' into inlineviewconfigs
acoates-ms Jul 6, 2020
b06be49
Mark babel-plugin-inline-view-configs private
acoates-ms Jul 6, 2020
8d4a1d8
Change files
acoates-ms Jul 6, 2020
410b47e
Undo accidental add of src\overrides.json
acoates-ms Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/playground/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
module.exports = {
presets: ['module:metro-react-native-babel-preset'],
plugins: [require('../../vnext/src/babel-plugin-inline-view-configs')],

@NickGerleman NickGerleman Jul 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding this to e2etest as well

};
3 changes: 3 additions & 0 deletions vnext/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,8 @@ temp
/third-party
/packages/

# Required to run babel-plugin-inline-view-configs - will be removed once the babel-plugin-inline-view-configs package is published
/babel-plugin-inline-view-configs

# Copied from root as part of build
/README.md
Loading