Skip to content

Fix Playground app crash on instance load #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
May 14, 2020
Merged

Fix Playground app crash on instance load #4896

1 commit merged into from
May 14, 2020

Conversation

@acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented May 13, 2020 •
edited by ghost
Loading

The playground app does not use ReactApplication, and so its required that it provides a UIDispatcher as part of the instance settings. - This was missed as part of #4877

This gets playground booting again.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner May 13, 2020 21:39
@acoates-ms acoates-ms added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label May 13, 2020
@ghost
Copy link

ghost commented May 13, 2020

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@asklar
Copy link
Member

asklar commented May 14, 2020 •
edited
Loading

The playground app does not use ReactApplication, and so its required that it provides a UIDispatcher as part of the instance settings. - This was missed as part of #4877

This gets playground booting again.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms could this be provided by RN for the app by default if it doesn't use ReactApplication and it doesn't provide its own UIDispatcher?

@ghost ghost merged commit fdcffd4 into microsoft:master May 14, 2020
@acoates-ms acoates-ms deleted the playgroundfix branch May 14, 2020 13:57
@NickGerleman
Copy link
Contributor

NickGerleman commented Jun 2, 2020

From earlier discussion, we were taking #5007 which removes this change. Removing the "Request Backport".

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoroz vmoroz vmoroz approved these changes

@dannyvv dannyvv dannyvv approved these changes

+1 more reviewer

@NickGerleman NickGerleman NickGerleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acoates-ms @asklar @NickGerleman @vmoroz @dannyvv @Khalef1