Skip to content

Update rnw-dependencies #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asklar merged 2 commits into from
May 13, 2020
Merged

Update rnw-dependencies #4894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf353d
don't exit the powershell session and pause for keyboard input if int…
asklar May 13, 2020
c8e6e51
Change files
asklar May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2020-05-13-14-16-07-rnw-dep-dontexit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "don't exit the powershell session and pause for keyboard input if interactive",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch",
"date": "2020-05-13T21:16:07.200Z"
}
8 changes: 5 additions & 3 deletions vnext/Scripts/rnw-dependencies.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,11 @@ foreach ($req in $requirements)
}

if ($NeedsRerun) {
Write-Output "Some dependencies are not met. Re-run with -Install to install them.";
exit 1;
Write-Error "Some dependencies are not met. Re-run with -Install to install them.";
if (!$NoPrompt) {
[System.Console]::ReadKey();
}
throw;
} else {
Write-Output "All mandatory requirements met";
exit 0;
}