Improve run_wdio to print out failed tests #4843

asklar · 2020-05-09T05:17:44Z

I'm going to break up my RNTester visual test PR (#4699) into independent pieces because it's too massive otherwise.

This part deals with improving run_wdio to report failed tests to the console, with stacks.
Fixes #4845.

Microsoft Reviewers: Open in CodeFlow

ghost · 2020-05-09T05:18:44Z

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

packages/E2ETest/run_wdio.js

NickGerleman · 2020-05-10T04:31:10Z

We should really consider incrementally adopting TS in all of the places we're still using raw JS. allowing implicit any in tsconfig means we can use existing code as is and just add types.

NickGerleman · 2020-05-10T04:31:25Z

Signing off, but removing automerge first so comments can be addressed

NickGerleman · 2020-05-10T04:32:24Z

packages/E2ETest/run_wdio.js

+          let name = attr.name;
+          failures[name] = {};
+          const testcases = res.testsuites.testsuite[i].testcase;
+          for (let j = 0; j < testcases.length; j++) {


nit: this could really use some whitespace to make it a bit more readable

Also named variables instead of indices. See the other comment about not using raw for loops.

the spacing matches what lint expects

I mean new lines. Lint doesn't care about those.

That doesn't seem to be the case.

@asklar Prettier will warn about Windows style line feeds depending on config. You'll want to change what your editor is set to likely. It should not complain about single new lines.

Actually I think it will also complain about empty lines that start directly after a conditional.

What I meant with "lint doesn't care about those" is that it won't add them for you,

packages/E2ETest/run_wdio.js

* improve treedump capabilities * Reenable V8 for desktop projects (#4840) * Delay load ChakraCore.dll * Change files * clean up unneeded project references * Overwrite property after React.Cpp.props gets included * Change files * change file * Fix WinUI3 * Reverse the conditional logic * Revert some unnecessary changes. Consolidate the preprocessor defines in the props Co-authored-by: tudorm <[email protected]> * applying package updates ***NO_CI*** * update masters * Improve run_wdio to print out failed tests (#4843) * Improve run_wdio to print out failed tests * Fire onLoad event when a bitmap image is opened (#4750) * Fire onLoad event when a bitmap image is opeed * Change files * add imageFailed * remove firing of onload events in the createImageBrush block so that load events don't fire twice. * Expose ability for apps to provide their own RedBox implementation (#4786) * Expose ability for apps to provide their own RedBox implementation * Change files * minor changes * Code review feedback * minor fix * format fixes * minor change * minor fix * minor fix * minor fix * Bump fp-ts from 2.5.4 to 2.6.0 (#4871) Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.5.4 to 2.6.0. - [Release notes](https://github.com/gcanti/fp-ts/releases) - [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md) - [Commits](gcanti/fp-ts@2.5.4...2.6.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * applying package updates ***NO_CI*** * Fixed ReactContext copy/move semantic (#4870) * Fixed ReactContext copy/move semantic * Change files * Fixed formatting * Test to show how to use a delegate in ReactPropertyBag * Add ReactNativeHost to Win32 C++/WinRT ABI (#4848) * create MS.ReactNative.IntegrationTests project * RNHost activation succeeds * update * update * Change files * add JS function call test * Change files * fix formatting * submit current state * ReactNativeHost activation test succeeds * Change files * account for property bag addition * sync, address code review feedback * Use spec file for DevSettings NativeModule (#4873) * Use spec file for DevSettings NativeModule * Change files * minor change * Handle HTTP errors in DevSupportManager. (#4880) * Handle HTTP connect exceptions in DevSupportManager * Change files * applying package updates ***NO_CI*** * Allow storing non-WinRT types in ReactPropertyBag (#4884) * Allow storing non-WinRT types in ReactPropertyBag * Change files * Addressed PR feedback * Use DispatcherQueue instead of CoreDispatcher for Mso::DispatchQueue (#4877) * Use DispatcherQueue instead of CoreDispatcher for Mso::DispatchQueue * Change files * Removed 'Thread' from some new API names. * Removed extra 'private' section in AppearanceModule * Temporary: use CoreDispatcher to check the E2E test * Avoid using DispatcherQueue::HasThreadAccess in earlier Windows versions. * RNW dependencies (#4876) * add rnw-dependencies.ps1 * Change files * --sln * run in CI * print * desktop appium is optional * use agent directory * 15GB is a ballpark estimate * optional space * . * support running from web (#4892) * Bump typescript from 3.8.3 to 3.9.2 (#4890) * Bump lerna from 3.20.2 to 3.21.0 (#4889) * BugFix: fix default tabindex stomping over acceptsKeyboardFocus (#4893) * Change files * revert dfc57fc * set default tab index to -1, the hope is to be in line with xbox assumption * xbox doesn't seem to rely on this, changing default back to match xaml default * Update e2e testing doc with CI debugging info (#4897) * add instructions for CI debugging for e2e test app * point e2e readme to e2e testing doc * Update rnw-dependencies (#4894) * don't exit the powershell session and pause for keyboard input if interactive * Change files * enable Switch (fixed 4596) * improve treedump capabilities * update masters * enable Switch (fixed 4596) * protect against exceptions in run_wdio * add another try block * update e2e testing and masters, fixes 4680 * publish wdio report and fix run_wdio typo bug * TreeDump should ignore collapsed object elements in an array * add info about run_wdio Co-authored-by: tudorms <[email protected]> Co-authored-by: tudorm <[email protected]> Co-authored-by: React-Native-Windows Bot <[email protected]> Co-authored-by: lamxdoan <[email protected]> Co-authored-by: Andrew Coates <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Vladimir Morozov <[email protected]> Co-authored-by: Andreas Eulitz <[email protected]> Co-authored-by: Julio César Rocha <[email protected]> Co-authored-by: kmelmon <[email protected]>

Improve run_wdio to print out failed tests

fbf5e58

asklar requested a review from a team as a code owner May 9, 2020 05:17

asklar added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label May 9, 2020

lint

0bffb2d

NickGerleman reviewed May 10, 2020

View reviewed changes

packages/E2ETest/run_wdio.js Outdated Show resolved Hide resolved

NickGerleman reviewed May 10, 2020

View reviewed changes

packages/E2ETest/run_wdio.js Outdated Show resolved Hide resolved

NickGerleman reviewed May 10, 2020

View reviewed changes

packages/E2ETest/run_wdio.js Show resolved Hide resolved

NickGerleman removed the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label May 10, 2020

NickGerleman approved these changes May 10, 2020

View reviewed changes

NickGerleman reviewed May 10, 2020

View reviewed changes

packages/E2ETest/run_wdio.js Outdated Show resolved Hide resolved

PR feedback

4359b8c

dannyvv approved these changes May 11, 2020

View reviewed changes

asklar merged commit cf658ba into microsoft:master May 11, 2020

asklar deleted the runwdio branch May 11, 2020 17:10

Improve run_wdio to print out failed tests #4843

Improve run_wdio to print out failed tests #4843

Uh oh!

Conversation

asklar commented May 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

ghost commented May 9, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NickGerleman commented May 10, 2020

Uh oh!

NickGerleman commented May 10, 2020

Uh oh!

NickGerleman May 10, 2020

Choose a reason for hiding this comment

Uh oh!

NickGerleman May 10, 2020

Choose a reason for hiding this comment

Uh oh!

asklar May 10, 2020

Choose a reason for hiding this comment

Uh oh!

NickGerleman May 10, 2020

Choose a reason for hiding this comment

Uh oh!

asklar May 10, 2020

Choose a reason for hiding this comment

Uh oh!

NickGerleman May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NickGerleman May 10, 2020

Choose a reason for hiding this comment

Uh oh!

NickGerleman May 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asklar commented May 9, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

NickGerleman May 10, 2020 •

edited

Loading