TextBox should have a default tabIndex of 0 #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lamxdoan
added a commit
to lamxdoan/react-native-windows
that referenced
this pull request
Feb 27, 2020
* TextBox should have a default tabIndex of 0 * Change files
kmelmon
pushed a commit
that referenced
this pull request
Feb 28, 2020
* TextBox should have a default tabIndex of 0 (#4204) * TextBox should have a default tabIndex of 0 * Change files * Set IsTabStop to false when tabIndex is negative (#4180) * Set IsTabStop to false when tabIndex is negative * Change files * remove unneeded static_cast * whoops actually did need the static_cast * clearValue and set -1 as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all TextInputs get tab focus last so we should to set the default tabIndex to 0.
Microsoft Reviewers: Open in CodeFlow