-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add GetFacebookReactInstance #3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
58d7462
GetFacebookReactInstance
ZihanChen-MSFT be62f8f
def
ZihanChen-MSFT 62e99ab
...
ZihanChen-MSFT 05efde7
Add __cdecl explicitly
ZihanChen-MSFT a48ce9a
Update ReactUWP.vcxproj
ZihanChen-MSFT a9234b8
Update E2ETest to use ReactApplication (#3715)
ddalp 4be30ff
applying package updates ***NO_CI***
rnbot 389b1e8
Update ParityStatus.md (#3555)
harinikmsft 8327564
Bump @microsoft/api-extractor from 7.6.1 to 7.7.0 (#3717)
dependabot-preview[bot] c1e6c72
Bump @microsoft/api-documenter from 7.6.1 to 7.7.2 (#3724)
dependabot-preview[bot] 647f988
Aligning Microsoft.Windows.CppWinRT Versions (#3733)
jonthysell 252434a
applying package updates ***NO_CI***
rnbot 49a3400
Bump @types/react-native from 0.60.22 to 0.60.24 (#3740)
dependabot-preview[bot] e9f575f
Bump @types/node from 10.17.6 to 10.17.7 (#3741)
dependabot-preview[bot] 13f13d7
Update CONTRIBUTING.md
kmelmon fd02682
Use ReactNative.V8JSI.Windows.0.1.6 and ReactNative.Hermes.Windows.0.…
licanhua 2d77e1f
applying package updates ***NO_CI***
rnbot 3526c7f
Reduce build time on pipeline (#3734)
licanhua 2e30bad
Add react-native-win32 package (#3762)
acoates-ms ab16dc0
Publish packages using access public
acoates-ms 0071c7b
applying package updates ***NO_CI***
rnbot d5fe42f
Miscellaneous fixes in ETW tracing and Systrace (#3745)
mganandraj b9c3c55
applying package updates ***NO_CI***
rnbot f65df84
Strongly typed value serialization and deserialization using IJSValue…
vmoroz d1f70ed
applying package updates ***NO_CI***
rnbot 024d35f
Update to [email protected] (#3769)
rnbot 3b5cc34
applying package updates ***NO_CI***
rnbot 7190da1
Fix toggle debugger setting issue with ReactApplication (#3767)
ddalp d99775e
applying package updates ***NO_CI***
rnbot ba05046
Delete .pch after build on pipeline (#3771)
licanhua 119e544
applying package updates ***NO_CI***
rnbot d7523a0
Redirect build directory to C: on vs2017-win2016 build machine (#3768)
licanhua 148f405
applying package updates ***NO_CI***
rnbot 1cb4133
ignore Bundle folder in sampleapps (#3778)
licanhua f1a38ab
Add tree dump utility to E2E test framework and fix Image border issu…
ddalp ff54b9a
applying package updates ***NO_CI***
rnbot 6c83446
merge from master
ZihanChen-MSFT f35ed1c
Update yarn.lock
ZihanChen-MSFT c3dce39
Change files
ZihanChen-MSFT 646dbbc
Merge branch 'master' into add-tm
ZihanChen-MSFT c0b5a0f
Added new unit test projects to ReactWindows-Universal solution. (#3775)
vmoroz ffa461d
applying package updates ***NO_CI***
rnbot 7780d88
Update document for removing ReleaseBundle and DebugBundle (#3702)
licanhua 81ab92f
applying package updates ***NO_CI***
rnbot ba3fafc
CLI reads name from app.json if it doesn't exist in package.json (#3781)
licanhua d71fbcc
applying package updates ***NO_CI***
rnbot a258407
Change CLI to add prompt if no --template parameter is supplied (#3784)
kmelmon fb13716
applying package updates ***NO_CI***
rnbot 3cef232
Conditionally use BitmapImage (#3712)
marlenecota 57db8f3
applying package updates ***NO_CI***
rnbot 3383f8b
Bump rnpm-plugin-windows from 0.3.8 to 0.4.0 (#3800)
dependabot-preview[bot] 589c934
Bump pretty-format from 24.8.0 to 24.9.0 (#3764)
dependabot-preview[bot] cb3bbac
Bump stacktrace-parser from 0.1.6 to 0.1.8 (#3765)
dependabot-preview[bot] cc1a91d
Bump @types/react-native from 0.60.24 to 0.60.25 (#3757)
dependabot-preview[bot] 3fb7d81
Port windowsbrush code into react-native-windows (#3789)
kmelmon 609b118
applying package updates ***NO_CI***
rnbot ac63e81
Make sure that C# and C++ SampleApp projects identifiers have proper …
vmoroz dc434f5
Removed Bridge sub-namespace in favor of Microsoft.ReactNative (#3804)
vmoroz 6a4d504
applying package updates ***NO_CI***
rnbot 328c91e
fixing case issues (#3806)
mike-kaufman 266b31e
Bump @react-native-community/cli from 2.9.0 to 2.10.0 (#3663)
dependabot-preview[bot] 9857d0d
reduce build flavors for RNWUniversalPR (#3773)
licanhua 6e0fb10
Bunch of style properties fixes and TreeDump utility updates (#3793)
ddalp 433d669
applying package updates ***NO_CI***
rnbot 2b39791
Get flow clean, and turn on flow-check during build (#3730)
acoates-ms 66893fd
applying package updates ***NO_CI***
rnbot 9bb7d51
SourceCode module should provide scriptURL when running livereload wi…
acoates-ms fc8ad0a
applying package updates ***NO_CI***
rnbot d216220
Remove remaining need for fork of RN for win32 JS (#3811)
acoates-ms 258b3cc
applying package updates ***NO_CI***
rnbot 6e07ec9
Export ability to query names of loaded native modules (master branch…
NickGerleman c8ccf61
applying package updates ***NO_CI***
rnbot 42acd93
Changed Microsoft.ReactNative to be independent from ReactUWP (#3809)
vmoroz f9fcc02
applying package updates ***NO_CI***
rnbot b89bd04
Allow UAP SDK to be in other folder other than ProgramFiles (#3815)
licanhua b2ab0c2
applying package updates ***NO_CI***
rnbot c45c827
Add InjectBundleContent target (#3821)
licanhua caeaaf7
applying package updates ***NO_CI***
rnbot 5877cfb
Bump @types/react-native from 0.60.25 to 0.60.28 (#3831)
dependabot-preview[bot] 2ae7f08
[Security] Bump handlebars from 4.1.2 to 4.5.3 (#3818)
dependabot-preview[bot] 5c3f4c3
Call StartAnimation on m_scaleCombined for ScaleX / ScaleY animations…
Thristhart d8352a9
applying package updates ***NO_CI***
rnbot 499403d
Remove remaining need for fork of RN for win32 JS (#3834)
acoates-ms b055943
applying package updates ***NO_CI***
rnbot e6191b8
Rename GetFacebookReactInstance
ZihanChen-MSFT 2c4ed97
Merge branch 'master' into add-tm
ZihanChen-MSFT af31d87
Merge branch 'add-tm' of https://github.com/ZihanChen-MSFT/react-nati…
ZihanChen-MSFT bd46b38
Fix code review comment
ZihanChen-MSFT 3481685
Update TurboModuleUtils.cpp
ZihanChen-MSFT be69794
Fix lint errors
ZihanChen-MSFT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
change/@office-iss-react-native-win32-2019-12-16-14-17-19-add-tm.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Add GetFacebookReactInstance :: uwp::Instance -> react::Instance", | ||
| "packageName": "@office-iss/react-native-win32", | ||
| "email": "[email protected]", | ||
| "commit": "f35ed1c42cd2a1d9ed098082bf97babe3bc9c8e6", | ||
| "date": "2019-12-16T22:16:35.515Z" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Add GetFacebookReactInstance :: uwpInstance -> react::Instance", | ||
| "packageName": "react-native-windows", | ||
| "email": "[email protected]", | ||
| "commit": "f35ed1c42cd2a1d9ed098082bf97babe3bc9c8e6", | ||
| "date": "2019-12-16T22:17:19.866Z" | ||
| } |
8 changes: 8 additions & 0 deletions
8
change/react-native-windows-extended-2019-12-16-14-17-19-add-tm.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Add GetFacebookReactInstance :: uwpInstance -> react::Instance", | ||
| "packageName": "react-native-windows-extended", | ||
| "email": "[email protected]", | ||
| "commit": "f35ed1c42cd2a1d9ed098082bf97babe3bc9c8e6", | ||
| "date": "2019-12-16T22:17:02.605Z" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| #include "pch.h" | ||
| #include <ReactUWPABI.h> | ||
| #include <TurboModuleUtils.h> | ||
| #include "../ABI/Instance_rt.h" | ||
|
|
||
| namespace react::uwp { | ||
|
|
||
| std::shared_ptr<facebook::react::Instance> __cdecl GetReactInstanceFromUwpInstance( | ||
| const winrt::react::uwp::Instance &uwpInstance) { | ||
| auto abiInstance = reinterpret_cast<ABI::react::uwp::Instance *>(winrt::get_abi(uwpInstance)); | ||
| auto reactInstance = abiInstance->getInstance(); | ||
| assert(reactInstance); | ||
| auto fbInstance = reactInstance->GetInnerInstance(); | ||
ZihanChen-MSFT marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| assert(fbInstance); | ||
| return fbInstance; | ||
| } | ||
|
|
||
| } // namespace react::uwp | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <winrt/react.uwp.h> | ||
|
|
||
| namespace facebook::react { | ||
| class Instance; | ||
| } | ||
|
|
||
| namespace react::uwp { | ||
| extern std::shared_ptr<facebook::react::Instance> __cdecl GetReactInstanceFromUwpInstance( | ||
| const winrt::react::uwp::Instance &uwpInstance); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I prefer if-else over assert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, it can't fail, or it is a bug. So I prefer to crash.