Skip to content

CLI reads name from app.json if it doesn't exist in package.json #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmelmon merged 2 commits into from
Dec 17, 2019
Merged

CLI reads name from app.json if it doesn't exist in package.json #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed24ef5
read name from app.json
licanhua Dec 16, 2019
4ed3194
Change files
licanhua Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/rnpm-plugin-windows-2019-12-16-13-38-43-nugetver.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "CLI detect project name from app.json",
"packageName": "rnpm-plugin-windows",
"email": "[email protected]",
"commit": "ed24ef5033bac55fb8f0db6ee727051521e4682c",
"date": "2019-12-16T21:38:43.643Z"
}
12 changes: 11 additions & 1 deletion current/local-cli/rnpm/windows/src/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,17 @@ const getReactNativeVersion = function () {

const getReactNativeAppName = function () {
console.log('Reading application name from package.json...');
return JSON.parse(fs.readFileSync('package.json', 'utf8')).name;
let name = JSON.parse(fs.readFileSync('package.json', 'utf8')).name;
if (!name) {
if (fs.existsSync('app.json')) {
console.log('Reading application name from app.json...');
name = JSON.parse(fs.readFileSync('app.json', 'utf8')).name;
}
}
if (!name) {
console.error('Please specify name in package.json or app.json');
}
return name;
};

/**
Expand Down