Skip to content

Fix toggle debugger setting issue with ReactApplication #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddalp merged 2 commits into from
Dec 13, 2019
Merged

Fix toggle debugger setting issue with ReactApplication #3767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76228b9
Fix toggle debugger setting issue with ReactApplication
Dec 12, 2019
80d79d2
Change files
Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2019-12-12-16-22-29-instanceSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "Fix toggle debugger setting issue with ReactApplication",
"packageName": "react-native-windows",
"email": "[email protected]",
"commit": "76228b95ceccaa87cc75563083415308805f914d",
"date": "2019-12-13T00:22:29.280Z"
}
15 changes: 7 additions & 8 deletions vnext/Microsoft.ReactNative/ReactInstanceCreator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,13 @@ struct ReactInstanceCreator : react::uwp::IReactInstanceCreator {
std::shared_ptr<react::uwp::IReactInstance> getInstance();
void markAsNeedsReload();

// TODO: Remove this wart. AFAIK, it was only added for the
// Universal.SampleApp It's here because of the abstract base class. The
// ReactInstanceSettings in this project has a UseWebDebugger property
// that should be used instead as it automatically "persists" by virtue
// of being attached to the ReactNativeHost.
void persistUseWebDebugger(bool /*useWebDebugger*/){};
// TODO: Remove too
void persistUseLiveReload(bool /*useliveReload*/){};
void persistUseWebDebugger(bool useWebDebugger) {
m_instanceSettings.UseWebDebugger(useWebDebugger);
Copy link
Contributor

@licanhua licanhua Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add test case on this?

};

void persistUseLiveReload(bool useliveReload) {
m_instanceSettings.UseLiveReload(useliveReload);
};

private:
Microsoft::ReactNative::ReactInstanceSettings m_instanceSettings{};
Expand Down