Miscellaneous fixes in ETW tracing + Systrace #3746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
approved these changes
Dec 10, 2019
|
|
||
| std::chrono::high_resolution_clock::time_point start_{std::chrono::high_resolution_clock::now()}; | ||
|
|
||
| std::chrono::high_resolution_clock::time_point start_{ |
Contributor
There was a problem hiding this comment.
Not directly related to this CR, but as a warning, high_resolution_clock can have unexpected behavior, like going backwards with things like daylights savings time. steady_clock won't do this, and is still implemented with QueryPerformanceCounter on Windows so you should get a high resolution.
NickGerleman
approved these changes
Dec 12, 2019
chrisglein
added
the
Needs: Author Feedback
ghost
added
the
no-recent-activity
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Contributor
|
Given devmain is already off of 0.59 and we've had some crash issues, I'm just going to close this. |
ghost
removed
the
no-recent-activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to backport the changes in the #3745 to 0.59-vnext-stable, and hence to devmain immediately.
Microsoft Reviewers: Open in CodeFlow