Skip to content

Introduce yarn workspace, and use beachball for publishing #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10 commits merged into from
Jul 24, 2019

Conversation

acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Jul 19, 2019

This gets us most of the way to supporting multiple packages within the RNW repo.

It introduces a yarn workspace which contains the vnext package and a placeholder, "additional" package, and it removes my hand rolled publishing logic in favor of beachball which will be able to handle version bumping and publishing multiple packages together, and will automatically generate changelogs.

For future checkins:

  • Introduce additional CI logic verifying that all changes have change files.
  • Add learna to orchestrate multi package builds.
  • Currently RN/** is marked as nohoist to reduce more churn. -- But for dev productivity we should look at getting that reduced in a future checkin.
Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner July 19, 2019 05:10
"workspaces": {
"packages": [
"packages/*",
"vnext"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should current be in here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Current will not be manged by beachball, or yarn. Since current and vnext both have the same package names, it confuses all the monorepo tools.

@acoates-ms acoates-ms added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jul 24, 2019
@ghost
Copy link

ghost commented Jul 24, 2019

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 407c083 into microsoft:master Jul 24, 2019
@acoates-ms acoates-ms deleted the beachball branch July 24, 2019 19:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants