Skip to content

Fix stackoverflow in StructInfo #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microsoft-github-policy-service merged 2 commits into from
Dec 6, 2025
Merged

Fix stackoverflow in StructInfo #15454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e1b9c
Fix stackoverflow in StructInfo
ivan-golubev Dec 5, 2025
ed49e38
Change files
vmoroz Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-8d23ba00-efa5-4506-b2cd-aff4b69cfa3f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix stackoverflow in StructInfo",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
9 changes: 8 additions & 1 deletion vnext/Microsoft.ReactNative.Cxx/StructInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ struct FieldInfo {
FieldInfo(TValue TClass::*fieldPtr) noexcept
: m_fieldReader{FieldReader<TClass, TValue>},
m_fieldWriter{FieldWriter<TClass, TValue>},
m_fieldPtrStore{*reinterpret_cast<uintptr_t *>(&fieldPtr)} {
m_fieldPtrStore{StoreFieldPtr(fieldPtr)} {
static_assert(sizeof(m_fieldPtrStore) >= sizeof(fieldPtr));
}

Expand All @@ -94,6 +94,13 @@ struct FieldInfo {
}

private:
template <class TClass, class TValue>
static uintptr_t StoreFieldPtr(TValue TClass::*fieldPtr) noexcept {
uintptr_t result{};
std::memcpy(&result, &fieldPtr, sizeof(fieldPtr));
return result;
}

FieldReaderType m_fieldReader;
FieldWriterType m_fieldWriter;
const uintptr_t m_fieldPtrStore;
Expand Down
Loading