SDL Compliance: Input Validation for Security Vulnerabilities issue: 58386087#15273

Draft

Nitin-100 wants to merge 30 commits intomicrosoft:mainfrom

Nitin-100:nitinc/issue/sdl/58386087

Commits on Nov 3, 2025

SDL Compliance: Input Validation for Security Vulnerabilities (#58386087)

Nitin Chaudhary
authored and
Nitin-100
committed
Change files

Nitin Chaudhary
authored and
Nitin-100
committed
Fix InputValidationTest.cpp - use ValidateFilePath instead of ValidateBundlePath

Nitin Chaudhary
authored and
Nitin-100
committed
Remove invalid tests - NumericValidator and HeaderValidator don't exist in API

Nitin Chaudhary
authored and
Nitin-100
committed
Fix InputValidationTest.cpp - remove tests for non-existent NumericValidator and HeaderValidator classes

Nitin Chaudhary
authored and
Nitin-100
committed
Fix linker errors - add Shared.vcxitems import to test project so InputValidation symbols are visible

Nitin Chaudhary
authored and
Nitin-100
committed
Apply clang-format to all SDL compliance files

Nitin Chaudhary
authored and
Nitin-100
committed
lint fix.

Nitin Chaudhary
authored and
Nitin-100
committed
Fix test project - add InputValidation files directly instead of importing Shared.vcxitems (avoids MIDL errors)

Nitin Chaudhary
authored and
Nitin-100
committed
Fix InputValidation.cpp compilation - disable precompiled headers

Nitin Chaudhary
authored and
Nitin-100
committed
Fix C4100 unreferenced parameter warning

Nitin Chaudhary
authored and
Nitin-100
committed
Apply formatting to InputValidation.cpp

Nitin Chaudhary
authored and
Nitin-100
committed
Fix HTTP validation to call callbacks before returning

Nitin Chaudhary
authored and
Nitin-100
committed
Allow localhost for testing - fix RequestOptionsSucceeds crash

Nitin Chaudhary
authored and
Nitin-100
committed
Move URL validation from WinRTHttpResource to HttpModule

Nitin Chaudhary
authored and
Nitin-100
committed
Fix: Allow localhost in HttpModule validation for testing

Nitin Chaudhary
authored and
Nitin-100
committed
Fix WebSocket validation same as HTTP

Nitin Chaudhary
authored and
Nitin-100
committed
Fix IPv6 private range validation

Nitin Chaudhary
authored and
Nitin-100
committed
Address Copilot AI review comments

Nitin Chaudhary
authored and
Nitin-100
committed
Fix IPv6 loopback expanded form detection

Nitin Chaudhary
authored and
Nitin-100
committed
Fix: Allow localhost in inspector URL validation for Metro packager

Nitin Chaudhary
authored and
Nitin-100
committed
feat: Add DNS validation for advanced SSRF protection

Nitin Chaudhary
authored and
Nitin-100
committed
lint fix

Nitin Chaudhary
authored and
Nitin-100
committed
Address PR review comments: Add centralized allowlists, specific exceptions, and validation improvements

Nitin Chaudhary
authored and
Nitin-100
committed
Address remaining 5 PR review comments

Nitin Chaudhary
authored and
Nitin-100
committed
Fix OInstance.cpp: Use m_devSettings instead of devSettings parameter

Nitin Chaudhary
authored and
Nitin-100
committed
Revert OInstance.cpp: Keep devSettings parameter (not m_devSettings)
Nitin Chaudhary
committed
refactor: Apply C++ best practices for SDL compliance
Nitin Chaudhary
committed
test: Update InputValidationTest to use std::exception
Nitin Chaudhary
committed
lint fixes.
Nitin Chaudhary
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SDL Compliance: Input Validation for Security Vulnerabilities issue: 58386087#15273

SDL Compliance: Input Validation for Security Vulnerabilities issue: 58386087#15273
Nitin-100 wants to merge 30 commits intomicrosoft:mainfrom
Nitin-100:nitinc/issue/sdl/58386087

Commits on Nov 3, 2025

SDL Compliance: Input Validation for Security Vulnerabilities (#58386087)

Change files

Fix InputValidationTest.cpp - use ValidateFilePath instead of ValidateBundlePath

Remove invalid tests - NumericValidator and HeaderValidator don't exist in API

Fix InputValidationTest.cpp - remove tests for non-existent NumericValidator and HeaderValidator classes

Fix linker errors - add Shared.vcxitems import to test project so InputValidation symbols are visible

Apply clang-format to all SDL compliance files

lint fix.

Fix test project - add InputValidation files directly instead of importing Shared.vcxitems (avoids MIDL errors)

Fix InputValidation.cpp compilation - disable precompiled headers

Fix C4100 unreferenced parameter warning

Apply formatting to InputValidation.cpp

Fix HTTP validation to call callbacks before returning

Allow localhost for testing - fix RequestOptionsSucceeds crash

Move URL validation from WinRTHttpResource to HttpModule

Fix: Allow localhost in HttpModule validation for testing

Fix WebSocket validation same as HTTP

Fix IPv6 private range validation

Address Copilot AI review comments

Fix IPv6 loopback expanded form detection

Fix: Allow localhost in inspector URL validation for Metro packager

feat: Add DNS validation for advanced SSRF protection

lint fix

Address PR review comments: Add centralized allowlists, specific exceptions, and validation improvements

Address remaining 5 PR review comments

Fix OInstance.cpp: Use m_devSettings instead of devSettings parameter

Revert OInstance.cpp: Keep devSettings parameter (not m_devSettings)

refactor: Apply C++ best practices for SDL compliance

test: Update InputValidationTest to use std::exception

lint fixes.