Skip to content

[WIP] TextComponent's e2e testing taking too long to complete #15098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+20 −5
Closed

[WIP] TextComponent's e2e testing taking too long to complete #15098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e275d03
Initial plan
Copilot Sep 1, 2025
0cfca48
Fix TextComponent e2e test performance by implementing proper TextRan…
Copilot Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,14 @@ void DumpUIAPatternInfo(IUIAutomationElement *pTarget, const winrt::Windows::Dat
winrt::com_ptr<ITextRangeProvider> textRangePattern;
hr = textPattern->get_DocumentRange(textRangePattern.put());
if (SUCCEEDED(hr) && textRangePattern) {
textRangePattern->GetText(20, &text);
if (SUCCEEDED(hr)) {
InsertStringValueIfNotEmpty(result, L"TextRangePattern.GetText", text);
// Clone the text range provider before accessing its methods to avoid hangs
winrt::com_ptr<ITextRangeProvider> clonedTextRange;
hr = textRangePattern->Clone(clonedTextRange.put());
if (SUCCEEDED(hr) && clonedTextRange) {
hr = clonedTextRange->GetText(20, &text);
if (SUCCEEDED(hr)) {
InsertStringValueIfNotEmpty(result, L"TextRangePattern.GetText", text);
}
}
}
}
Expand Down
14 changes: 12 additions & 2 deletions vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextRangeProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,18 @@ CompositionTextRangeProvider::CompositionTextRangeProvider(
}

HRESULT __stdcall CompositionTextRangeProvider::Clone(ITextRangeProvider **pRetVal) {
// no-op
*pRetVal = nullptr;
if (pRetVal == nullptr)
return E_POINTER;

auto strongView = m_view.view();
if (!strongView)
return UIA_E_ELEMENTNOTAVAILABLE;

// Create a new instance of CompositionTextRangeProvider with the same view and parent provider
auto clonedProvider = winrt::make<CompositionTextRangeProvider>(
strongView.as<winrt::Microsoft::ReactNative::Composition::ComponentView>(), m_parentProvider.get());

*pRetVal = clonedProvider.detach();
return S_OK;
}

Expand Down