Skip to content

Conversation

@vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Aug 1, 2025

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

To Support announceForAccessibility in Fabric

Resolves [ #14296 ]

What

In reactnativeisand we used a InputFocusController.GotFocus event , to listen to when the React Native island is focused. Then keeping track of that as property on the react context, to allow the native module to access it.

Screenshots

AnnounceForAccessibility.mp4

Optional: Tested in playground.

Changelog

Should this change be included in the release notes: yes

Support for announceForAccessibility in AccessibiltyInfo Module is added

Microsoft Reviewers: Open in CodeFlow

@vineethkuttan vineethkuttan marked this pull request as ready for review August 1, 2025 11:15
@vineethkuttan vineethkuttan requested review from a team as code owners August 1, 2025 11:15
@vineethkuttan vineethkuttan force-pushed the impAnnounceForAccessibility branch from e550b01 to a61d12d Compare August 1, 2025 11:20
@vineethkuttan vineethkuttan requested a review from Copilot August 1, 2025 13:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the announceForAccessibility function in the AccessibilityInfo module for Fabric architecture by integrating with the React Native Island's focus management system. The implementation uses UIA (UI Automation) notification events to provide accessibility announcements when the React Native island is focused.

Key Changes

  • Adds Fabric-specific implementation for announceForAccessibility using UIA notification events
  • Introduces a React property to track and access the ReactNativeIsland instance from native modules
  • Sets up focus event handling to store the island reference in the React context when focused

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AccessibilityInfoModule.cpp Adds Fabric-specific announceForAccessibility implementation using UIA events
ReactNativeIsland.h Declares static property method for ReactNativeIsland access
ReactNativeIsland.cpp Implements property method and focus event handler to store island reference
react-native-windows-b93a8310-8489-4f09-8497-eb5807c505b9.json Adds changelog entry for the new feature
react-native-windows-a7eded58-5a2a-479b-b48e-19ebcd5e6e2b.json Removes unrelated changelog entry
@rnw-scripts-generate-release-notes-d4a4f9cb-19ee-4dac-a467-95b8a8365643.json Removes unrelated changelog entry
@react-native-windows-cli-55399dd7-6f33-4e76-82c7-1832ffab3efa.json Removes unrelated changelog entry

@vineethkuttan vineethkuttan changed the title [Fabric] Implement announceForAccessibility in AccessibiltyInfo Module [Fabric] Implement announceForAccessibility in AccessibilityInfo Module Aug 1, 2025
Copy link
Contributor

@anupriya13 anupriya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nit comments rest changes looks good!

@vineethkuttan vineethkuttan merged commit dea9967 into microsoft:main Aug 6, 2025
58 checks passed
@vineethkuttan vineethkuttan deleted the impAnnounceForAccessibility branch August 7, 2025 06:17
vineethkuttan added a commit that referenced this pull request Sep 2, 2025
…le (#14995)

* Implementation of announce for accessibility for fabric

* Build fix

* Removed Debug Message

* Yarn Change

* Copilot Suggestions

* Review Changes

* Storing the weak_ref island in property to avoid circular ref

* Adding deleted Change Files
vineethkuttan added a commit that referenced this pull request Sep 2, 2025
…#15105)

* [Fabric] Implement announceForAccessibility in AccessibilityInfo Module (#14995)

* Implementation of announce for accessibility for fabric

* Build fix

* Removed Debug Message

* Yarn Change

* Copilot Suggestions

* Review Changes

* Storing the weak_ref island in property to avoid circular ref

* Adding deleted Change Files

* [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023)

* Update Toggle State to Narrator

* Yarn Change

* Review Changes

* Review Changes 2.0

* [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088)

* Few more implementation of TextRange Provider

* Yarn change

* Update Change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants