Skip to content

Conversation

@anupriya13
Copy link
Contributor

@anupriya13 anupriya13 commented Apr 21, 2025

Description

[Fabric] Implement snapToStart, snapToEnd, snapToInterval and snapToOffsets in ScrollView

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
[Fabric] Implement snapToStart, snapToEnd, snapToInterval and snapToOffsets in ScrollView

Resolves

What

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
[Fabric] Implement snapToStart, snapToEnd, snapToInterval and snapToOffsets in ScrollView

Refer https://github.com/facebook/react-native/blob/618279508159191f2b11c0b20446f91e82a27abf/packages/react-native/React/Views/ScrollView/RCTScrollView.m#L786

Screenshots

Add any relevant screen captures here from before or after your changes.

Testing

If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.

  • playground tested

Optional: Describe the tests that you ran locally to verify your changes.

Changelog

Should this change be included in the release notes: indicate yes or no
YES

Add a brief summary of the change to use in the release notes for the next release.
[Fabric] Implement snapToStart, snapToEnd, snapToInterval and snapToOffsets in ScrollView

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@acoates-ms acoates-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do snap points using inertia modifiers as described here:
https://learn.microsoft.com/en-us/windows/uwp/composition/inertia-modifiers

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Apr 21, 2025
@anupriya13
Copy link
Contributor Author

@anupriya13 anupriya13 closed this Apr 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot)

Projects

None yet

2 participants