-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implementation for onContentSizeChange property for TextInput for fabric #14479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bbe8b68
Implement the onContentSizeChange property for the fabric implementat…
satkh 58ce921
Revert "Implement the onContentSizeChange property for the fabric imp…
satkh 0a4efcf
Merge branch 'main' of https://github.com/microsoft/react-native-windows
satkh d9d3292
Implemention for TextInput onContentSizeChange property for the fabric
satkh 15472f8
adding lint and format changes
satkh 1c37812
Change files
satkh 254e821
Fixing lint errors
satkh 20ec6c2
Merge branch 'main' into user/satkh/textInput_onContentSizeChangeProp_1
satkh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/react-native-windows-ac5a5021-6294-47db-b9ef-14f49d38b108.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Implement the onContentSizeChange property for the fabric implementation of TextInput.", | ||
"packageName": "react-native-windows", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this is the content size. This is the size of the textinput - But I think onContentSize is supposed to be the size of the text content. So if there is more text that fits within the TextInput bounds, and the TextInput starts scrolling, then onContentSize would report a value larger than the layoutMetrics.frame.size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, verified in Expo Snack - In 2 line multiline textinput, as I add more and more lines of text the contentSize increases even through the textinput itself does not increase in size.