Skip to content

[0.77][Fabric] Add Support for ScrollProvider #14425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiaramooney merged 8 commits into from
Mar 18, 2025
Merged

[0.77][Fabric] Add Support for ScrollProvider #14425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a72642
[Fabric] Add Support for ScrollProvider (#14411)
chiaramooney Mar 12, 2025
4a89fbf
Merge
chiaramooney Mar 13, 2025
fdd0db9
Fix Build
chiaramooney Mar 13, 2025
a5b28b7
Merge
chiaramooney Mar 13, 2025
c3eddc9
Format + Merge Conflicts
chiaramooney Mar 13, 2025
4af4539
Merge branch '0.77-stable' of https://github.com/microsoft/react-nati…
chiaramooney Mar 13, 2025
4e77972
Update Snapshots
chiaramooney Mar 17, 2025
5616f35
Merge branch '0.77-stable' of https://github.com/microsoft/react-nati…
chiaramooney Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-7d072016-5414-4327-b40c-a149c1dc34b9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add IScrollProvider Implementation",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 2 additions & 3 deletions packages/e2e-test-app-fabric/test/ScrollViewComponentTest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ describe('ScrollView Tests', () => {
const dump = await dumpVisualTree('flash_scroll_indicators_button');
expect(dump).toMatchSnapshot();
});
// Disable tests where testID is not found.
/*test('ScrollViews can scroll an item list horizontally', async () => {
test('ScrollViews can scroll an item list horizontally', async () => {
const component = await app.findElementByTestID('scroll_horizontal');
await component.waitForDisplayed({timeout: 20000});
const dump = await dumpVisualTree('scroll_horizontal');
expect(dump).toMatchSnapshot();
});*/
});
test('ScrollView has scrollTo method, scroll to start button', async () => {
const component = await app.findElementByTestID('scroll_to_start_button');
await component.waitForDisplayed({timeout: 20000});
Expand Down
84 changes: 46 additions & 38 deletions packages/e2e-test-app-fabric/test/__snapshots__/AccessibilityTest.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,50 +245,58 @@ exports[`Accessibility Tests Selectable items must have a Selection Container. E
"SelectionPattern.IsSelectionRequired": true,
"__Children": [
{
"AutomationId": "Selectable item 1",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 1",
"AutomationId": "",
"ControlType": 50033,
"LocalizedControlType": "pane",
"Name": "List of selectable items",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 1",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 1",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
{
"AutomationId": "Selectable item 2",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 2",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 2",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 2",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
{
"AutomationId": "Selectable item 3",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 3",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
"AutomationId": "Selectable item 3",
"ControlType": 50000,
"IsKeyboardFocusable": true,
"LocalizedControlType": "button",
"Name": "Selectable item 3",
"__Children": [
{
"AutomationId": "",
"ControlType": 50020,
"LocalizedControlType": "text",
"Name": "Unselected",
"TextRangePattern.GetText": "Unselected",
},
],
},
],
},
Expand Down
Loading
Loading