Update some packages*.json files after the WinAppSDK udpate #14056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like SampleAppFabric is also on the old WinAppSDK: |
Thanks! I've now found and ran the script "NuGetRestoreForceEvaluateAllSolutions.ps1" which does what we need. I've verified that after this there are no references to the old version number (1.5.240227000). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
Yajur-Grover
approved these changes
Oct 31, 2024
JesseCol
force-pushed
the
update-winappsdk-2
branch
from
296d536
to
f7c4b2e
Compare
JesseCol
force-pushed
the
update-winappsdk-2
branch
from
f7c4b2e
to
e49ad2f
Compare
JesseCol
force-pushed
the
update-winappsdk-2
branch
from
e49ad2f
to
133540a
Compare
marlenecota
approved these changes
Oct 31, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
TatianaKapos
approved these changes
Nov 1, 2024
Thanks for looking! Yes, looks like we should backport to 0.76 because the first part of the WinAppSDK update is there. Can you point me to instructions? |
Yajur-Grover
pushed a commit
to Yajur-Grover/react-native-windows
that referenced
this pull request
Nov 4, 2024
…t#14056) * Update some packages*.json files after the WinAppSDK udpate * Found and ran the NuGetRestoreForceEvaluateAllSolutions.ps1 script * Change files
TatianaKapos
added a commit
that referenced
this pull request
Nov 7, 2024
…14078) * Update some packages*.json files after the WinAppSDK udpate (#14056) * Update some packages*.json files after the WinAppSDK udpate * Found and ran the NuGetRestoreForceEvaluateAllSolutions.ps1 script * Change files * Change files --------- Co-authored-by: JesseCol <[email protected]> Co-authored-by: Tatiana Kapos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did a WinAppSDK update recently, there are some packages*.json files that I missed when doing that update.
Type of Change
Why
Without this change, the "e2e-test-app-fabric" doesn't build successfully.
What
This change modifies some *.json files so the new version of WindowsAppSDK is the expected version.
I found and ran the script "NuGetRestoreForceEvaluateAllSolutions.ps1"
Testing
cd packages\e2e-test-app-fabric
yarn windows --no-launch --no-deploy
Microsoft Reviewers: Open in CodeFlow