Support WinAppSDK + cppwinrt 2.240111.5 #12862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See microsoft/cppwinrt#1393 We need to first convert the WinUI 3 control to IControlProtected to access GetTemplateChild.
|
Why is this only an issue with WinUI3? Wasn't this method protected in WinUI2 too? |
@acoates-ms Just noticed this as well when trying to use the upgraded version of cppwinrt with a UWP / WinUI2 app |
acoates-ms
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
See microsoft/cppwinrt#1393
What
We need to first convert the WinUI 3 control to IControlProtected to access GetTemplateChild.
Testing
Compiled with WinAppSDK and cppwinrt v2.0.240111.5
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow