[0.72] Release long lived JSI objects ASAP#12388
Merged
microsoft-github-policy-service[bot] merged 3 commits intoNov 14, 2023
Merged
Conversation
JunielKatarn
approved these changes
Nov 14, 2023
vmoroz
added
the
AutoMerge
vmoroz
deleted the
PR/0.72-Fix_memory_leaks_in_long_lived_jsi_objects
branch
November 14, 2023 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick PR #12385
Type of Change
Why
While investigating memory leaks in RNW code I saw that we almost never delete objects from the JSI long lived object collection.
What
In this PR we release JSI long-lived objects as soon as we finish using them.
After this change, the list of long-lived objects is regularly cleaned.
Microsoft Reviewers: Open in CodeFlow