ABI-safe Hermes API and new JSI for Node-API #11696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # vnext/Shared/Shared.vcxitems.filters
vmoroz
changed the title
acoates-ms
reviewed
Jun 12, 2023
vnext/Shared/JSI/V8RuntimeHolder.cpp
Outdated
|
|
||
| class V8FuncResolver : public IFuncResolver { | ||
| public: | ||
| // TODO: (vmoroz) Use Office safe DLL loading |
Contributor
There was a problem hiding this comment.
Can we either do this, or file an issue to follow up on it?
Member
Author
There was a problem hiding this comment.
Good catch! I will do it before merging.
acoates-ms
reviewed
Jun 12, 2023
|
|
||
| m_jsiRuntime = | ||
| makeNodeApiJsiRuntime(env, &api, [runtime]() { CRASH_ON_ERROR(V8Api::current()->jsr_delete_runtime(runtime)); }); | ||
| m_ownThreadId = std::this_thread::get_id(); |
Contributor
There was a problem hiding this comment.
This is just used for the validation in getRuntime right?
I dont think this is a valid check for fabric, since fabric will sometimes run the runtime the UI thread.
Member
Author
There was a problem hiding this comment.
Good point! Let me see if I can remove it.
Contributor
|
Looks good other than the thread id check. |
acoates-ms
approved these changes
Jun 13, 2023
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Jun 13, 2023
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Jun 14, 2023
acoates-ms
pushed a commit
that referenced
this pull request
Jun 14, 2023
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Jun 14, 2023
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Jun 15, 2023
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Jun 20, 2023
…t#11696) (microsoft#11757)" This reverts commit 7a340bd.
vmoroz
added a commit
to vmoroz/microsoft-react-native-windows
that referenced
this pull request
Aug 16, 2023
vmoroz
added a commit
that referenced
this pull request
Aug 17, 2023
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Sep 15, 2023
…t#11696) (microsoft#12033)" This reverts commit fbed06a.
JunielKatarn
added a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR has the following set of changes:
Microsoft Reviewers: Open in CodeFlow