-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix parsing of empty build props in run-windows (#13665)
## Description This PR fixes the two issues with `run-windows --msbuildprops` 1. When passing nothing, the command should not error and exit 2. When the string is parsed into key/value pairs, do not add empty keys to the msbuild command (which will cause msbuild to fail) ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why Ran into these issues while working on PR #13634, extracted them as general bug fixes here. ### What See above. ## Screenshots N/A ## Testing Verified running `run-windows` with malformed `--msbuildprops` no longer errors. ## Changelog Should this change be included in the release notes: _yes_ Fix parsing of empty build props in run-windows
- Loading branch information
1 parent
409bf6e
commit 6bddf6a
Showing
3 changed files
with
15 additions
and
4 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@react-native-windows-cli-81405bf2-50e6-426f-8c7a-81c622d5fa43.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "prerelease", | ||
"comment": "Fix parsing of empty build props in run-windows", | ||
"packageName": "@react-native-windows/cli", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters