Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Initial test app #96

Merged
merged 13 commits into from
Jun 3, 2020
Merged

macOS: Initial test app #96

merged 13 commits into from
Jun 3, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 29, 2020 •
edited
Loading

react-native-test-app-macos
Closes #87.

@tido64 tido64 added the platform: macOS This affects macOS label May 29, 2020
@tido64 tido64 requested review from alloy and tom-un May 29, 2020 19:10
@tido64 tido64 force-pushed the tido/macos branch 5 times, most recently from d8a3827 to 681c02f Compare May 30, 2020 12:23
@tido64 tido64 self-assigned this May 31, 2020
alloy
alloy reviewed Jun 2, 2020
View reviewed changes
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice ✨

ios/use_react_native-0.60.rb Outdated Show resolved Hide resolved
ios/use_react_native-0.60.rb Outdated Show resolved Hide resolved
macos/ReactTestApp/AppDelegate.swift Outdated Show resolved Hide resolved
macos/ReactTestAppUITests/ReactTestAppUITests.swift Outdated Show resolved Hide resolved
scripts/xcodebuild.sh Outdated Show resolved Hide resolved
scripts/xcodebuild.sh Outdated Show resolved Hide resolved
tido64 added 3 commits June 2, 2020 15:07
@tido64
Address comments
cf03413 
- Fix pod path checks
- Use `NSApplication.shared.keyWindow`
- Use `simctl` to get device id
- Check for `xcpretty`
@tido64
Use device_name
70e6498
@tido64
Remove empty tests
8c60401
@tido64 tido64 marked this pull request as ready for review June 2, 2020 14:53
@alloy
Copy link
Member

alloy commented Jun 3, 2020

:shipit:

@alloy alloy merged commit f84e73d into master Jun 3, 2020
@alloy alloy deleted the tido/macos branch June 3, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alloy alloy alloy left review comments

@tom-un tom-un Awaiting requested review from tom-un

Assignees

@tido64 tido64

Labels
platform: macOS This affects macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement macOS test app
2 participants
@tido64 @alloy