-
Notifications
You must be signed in to change notification settings - Fork 98
fix(android): automatically configure Gradle wrapper #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c7cc3a to
1687f97
Compare
6 tasks
To disable this behavior, set `RNTA_CONFIGURE_GRADLE_WRAPPER=0`.
1687f97 to
5d788b8
Compare
kelset
reviewed
Mar 26, 2024
kelset
approved these changes
Mar 26, 2024
Contributor
kelset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Tested the whole flow locally and it works great.
Let's ![]()
33 tasks
24 tasks
20 tasks
23 tasks
25 tasks
25 tasks
20 tasks
14 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: Android
This affects Android
platform: iOS
This affects iOS
platform: macOS
This affects macOS
platform: visionOS
platform: Windows
This affects Windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically configure Gradle wrapper. To disable this behavior, set
RNTA_CONFIGURE_GRADLE_WRAPPER=0.Basically, this is what the script does:
Platforms affected
Test plan
npm run set-react-version 0.71 -- --core-onlyexample/android/gradle/wrapper/gradle-wrapper.propertiesis unmodifiedyarncd example && yarn androidexample/android/gradle/wrapper/gradle-wrapper.properties)npm run set-react-version 0.73 -- --core-onlyyarncd example && yarn androidnpm run set-react-version 0.72 -- --core-onlyyarncd example && yarn androidnpm run set-react-version 0.71 -- --core-onlyyarncd example && RNTA_CONFIGURE_GRADLE_WRAPPER=0 yarn android