Apply changes from code review

microsoft · Jul 27, 2020 · cb44909 · cb44909
1 parent 9bfcbe7
commit cb44909
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/windows/.gitignore b/windows/.gitignore
@@ -10,7 +10,7 @@
 [Dd]ebugPublic/
 [Rr]elease/
 [Rr]eleases/
-**/AppPackages/**
+AppPackages/
 x64/
 x86/
 build/

diff --git a/windows/ReactTestApp/MainPage.cpp b/windows/ReactTestApp/MainPage.cpp
@@ -49,8 +49,9 @@ namespace winrt::ReactTestApp::implementation
         }
     }
 
-    IAsyncAction MainPage::OnNavigatedTo(NavigationEventArgs)
+    IAsyncAction MainPage::OnNavigatedTo(NavigationEventArgs const &e)
     {
+        Base::OnNavigatedTo(e);
         bool devServerIsRunning = co_await ::ReactTestApp::IsDevServerRunning();
         if (devServerIsRunning) {
             reactInstance_.LoadJSBundleFrom(::ReactTestApp::JSBundleSource::DevServer);

diff --git a/windows/ReactTestApp/MainPage.h b/windows/ReactTestApp/MainPage.h
@@ -12,8 +12,9 @@ namespace winrt::ReactTestApp::implementation
                               Windows::UI::Xaml::RoutedEventArgs);
         void LoadFromDevServer(Windows::Foundation::IInspectable const &,
                                Windows::UI::Xaml::RoutedEventArgs);
-        winrt::Windows::Foundation::IAsyncAction
-            OnNavigatedTo(Windows::UI::Xaml::Navigation::NavigationEventArgs);
+        Windows::Foundation::IAsyncAction
+        OnNavigatedTo(Windows::UI::Xaml::Navigation::NavigationEventArgs const &e);
+        using Base = MainPageT;
 
     private:
         ::ReactTestApp::ReactInstance reactInstance_;

diff --git a/windows/ReactTestApp/ReactInstance.cpp b/windows/ReactTestApp/ReactInstance.cpp
@@ -12,7 +12,6 @@ using winrt::Windows::Web::Http::HttpClient;
 
 namespace ReactTestApp
 {
-
     void ReactInstance::LoadJSBundleFrom(JSBundleSource source)
     {
         auto instanceSettings = reactNativeHost_.InstanceSettings();
@@ -55,14 +54,13 @@ namespace ReactTestApp
             }
         }
 
-        return "";  // TODO handle bundle not present
+        return "";
     }
 
     IAsyncOperation<bool> IsDevServerRunning()
     {
         Uri uri = Uri(L"http://localhost:8081/status");
         HttpClient httpClient;
-        std::wstring httpResponseBody;
         try {
             auto r = co_await httpClient.GetAsync(uri);
             co_return r.IsSuccessStatusCode();