ci: Disable Xcode tests #2298
Merged
ci: Disable Xcode tests #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can only see a changed comment. Did you mean to disable anything or was that already done in a different PR? |
No, I'm dumb and forgot to comment everything out below the comment 🫠 |
tido64
approved these changes
Nov 29, 2024
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Dec 3, 2024
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Dec 3, 2024
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These test tend to be flaky, giving a false negative for many PRs. They tend to be disabled upstream as well. Let's disable them here in our CI while we are mass merging Fabric commits
Test Plan:
CI should pass