ci: Use Ubuntu for publish job #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
reviewed
Oct 30, 2024
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
Saadnajmi
changed the title
Saadnajmi
force-pushed
the
fix-publish-2
branch
from
678678c to
64ad34b
Compare
tido64
reviewed
Oct 30, 2024
dannyvv
approved these changes
Oct 30, 2024
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Oct 30, 2024
* Revert "ci: Use the same VM image for PR and publish" This reverts commit e2b6374. * ci: specify publish pool with `os` * Use Ubuntu instead
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Oct 30, 2024
* Revert "ci: Use the same VM image for PR and publish" This reverts commit e2b6374. * ci: specify publish pool with `os` * Use Ubuntu instead
Saadnajmi
added a commit
that referenced
this pull request
Nov 14, 2024
* Revert "ci: Use the same VM image for PR and publish" This reverts commit e2b6374. * ci: specify publish pool with `os` * Use Ubuntu instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#2255 removed the
oskey from the YAML, which broke our publish. Also apparently I'm not allowed to use variables.Since it's hard to find a suitable macOS image and I probably don't need a macOS image for what is just a JS publish.. let's switch to Ubuntu. Specifically, the same image/pool as the other publish job so we know it will work.
Test Plan:
Ran a publish pipeline run on a clone of this branch and it ran successfully.