Skip to content

Revert "[Bug Fix] [React Native New Architecture]: Narrator is not announcing any success message on invoking 'Copy to clipboard' button." #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anupriya13 merged 1 commit into from
Aug 27, 2025
Merged

Revert "[Bug Fix] [React Native New Architecture]: Narrator is not announcing any success message on invoking 'Copy to clipboard' button." #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 13 additions & 29 deletions NewArch/src/examples/ClipboardExamplePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
import React, {useState} from 'react';
import {Button, Text, TextInput, View} from 'react-native';
import {AccessibilityInfo, Button, Text, TextInput, View} from 'react-native';
import {Example} from '../components/Example';
import {Page} from '../components/Page';
import Clipboard from '@react-native-clipboard/clipboard';
Expand All @@ -12,8 +12,6 @@ export const ClipboardExamplePage: React.FunctionComponent<{navigation?: any}> =
'This text will be copied to the clipboard',
);
const [textFromClipboard, setTextFromClipboard] = useState('');
const [accessibilityValueCopy, setAccessibilityValueCopy] = useState('');
const [accessibilityValuePaste, setAccessibilityValuePaste] = useState('');
const example1jsx = `<Button
title="Copy text to the Clipboard"
onPress={() => Clipboard.setString(textToCopy)}/>`;
Expand Down Expand Up @@ -49,25 +47,18 @@ export const ClipboardExamplePage: React.FunctionComponent<{navigation?: any}> =
<Button
ref={firstClipboardButtonRef}
accessibilityLabel="Copy text to the Clipboard"
accessibilityValue={{text: accessibilityValueCopy}}
title="Copy text to the Clipboard"
onPress={() => {
Clipboard.setString(textToCopy);
// Issue #622: Workaround
// AccessibilityInfo.announceForAccessibility(
// 'Text copied to clipboard',
// );
setAccessibilityValueCopy(''); // reset before reading to update on multiple clicks
setAccessibilityValueCopy('Text copied to clipboard');
AccessibilityInfo.announceForAccessibility(
'Text copied to clipboard',
);
}}
onAccessibilityTap={() => {
Clipboard.setString(textToCopy);
// Issue #622: Workaround
// AccessibilityInfo.announceForAccessibility(
// 'Text copied to clipboard',
// );
setAccessibilityValueCopy('');
setAccessibilityValueCopy('Text copied to clipboard');
AccessibilityInfo.announceForAccessibility(
'Text copied to clipboard',
);
}}
/>
<TextInput
Expand All @@ -82,25 +73,18 @@ export const ClipboardExamplePage: React.FunctionComponent<{navigation?: any}> =
<View style={{alignItems: 'flex-start', gap: 12}}>
<Button
accessibilityLabel="Paste text from the Clipboard"
accessibilityValue={{text: accessibilityValuePaste}}
title="Paste text from the Clipboard"
onPress={() => {
getClipboardText();
// Issue #622: Workaround
// AccessibilityInfo.announceForAccessibility(
// 'Text pasted from clipboard',
// );
setAccessibilityValuePaste('');
setAccessibilityValuePaste('Text pasted from clipboard');
AccessibilityInfo.announceForAccessibility(
'Text pasted from clipboard',
);
}}
onAccessibilityTap={() => {
getClipboardText();
// Issue #622: Workaround
// AccessibilityInfo.announceForAccessibility(
// 'Text pasted from clipboard',
// );
setAccessibilityValuePaste('');
setAccessibilityValuePaste('Text pasted from clipboard');
AccessibilityInfo.announceForAccessibility(
'Text pasted from clipboard',
);
}}
/>
<Text>{textFromClipboard}</Text>
Expand Down