Skip to content

Cannot build repo with additional development dependencies #447

@chrisglein

Description

@chrisglein

These are a result of this PR: #347

The first is common:

 × Build failed with message 5:10>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.18362.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\GitHub\react-native-gallery2\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj]. Check your build configuration.
Command failed. Re-run the command with --logging for more information.
error Command failed with exit code 2302.

Traditional fix for that is to patch the module with an updated vcxproj that downgrades the SDK requirement (and submit a PR upstream). Like this: react-native-picker/picker#483

If you do that, there's more:

 × Build failed with message 17:10>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(457,5): error MSB8020: The build tools for 'v142' application Type UWP (Platform Toolset = 'Visual Studio 2019') cannot be found. Please install the workflow for this application type and include the build tools for the  [D:\GitHub\react-native-gallery2\node_modules\lottie-react-native\src\windows\cppwinrt\LottieReactNative.vcxproj]. Check your build configuration.
Command failed. Re-run the command with --logging for more information.
error Command failed with exit code 2302.

Our dependency script no longer installs the v142 build tools (microsoft/react-native-windows#8750).
The lottie module is requiring that, and should be patched to work with just the v143 tools.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions