Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mimalloc build infra #1281

Closed
billti opened this issue Mar 20, 2024 · 0 comments · Fixed by #1320
Closed

Update mimalloc build infra #1281

billti opened this issue Mar 20, 2024 · 0 comments · Fixed by #1320
Assignees
@idavis
Labels
enhancement New feature or request

Comments

@billti
Copy link
Member

billti commented Mar 20, 2024

We should use a submodule which doesn't require cmake, ninja, etc. and only uses a C compiler with vendored sources. We should also remove the WoA64 exclusion and build all native binaries with the same allocator.
@billti billti added enhancement New feature or request needs triage labels Mar 20, 2024
@idavis idavis mentioned this issue Mar 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@idavis
Mimalloc is vendored instead of fetched (#1320)
91589c3 
These changes copy a snapshot of the Mimalloc source from `v2.1.2` into
the mimalloc-sys folder so that we no longer need to use cmake to fetch
and prepare the source. This also fixes `aarch64` Windows
cross-compilation issues caused by cmake generators.

I have addressed all DevSkim feedback and nothing was applicable or
actionable.

I've run the release build and everything compiles. It shows a red X in
the checks as I cancelled the second half of the build to prevent the
release from going out.

Closes #1281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idavis idavis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mimalloc is vendored instead of fetched microsoft/qsharp
2 participants
@idavis @billti